From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/229 Path: news.gmane.org!not-for-mail From: =?UTF-8?B?THVrYSBNYXLEjWV0acSH?= Newsgroups: gmane.linux.lib.musl.general Subject: Re: cluts comments Date: Wed, 03 Aug 2011 19:38:30 +0200 Message-ID: <4E398796.7080509@gmail.com> References: <20110803170406.GP29562@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1312393235 25540 80.91.229.12 (3 Aug 2011 17:40:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 3 Aug 2011 17:40:35 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-313-gllmg-musl=m.gmane.org@lists.openwall.com Wed Aug 03 19:40:32 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QofQm-00028Y-5M for gllmg-musl@lo.gmane.org; Wed, 03 Aug 2011 19:40:32 +0200 Original-Received: (qmail 21834 invoked by uid 550); 3 Aug 2011 17:40:31 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 21826 invoked from network); 3 Aug 2011 17:40:31 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=vblAOXbN8XD1ZVcTJYuTia+jWW7+p37ZUuHsKqyFXm8=; b=eUbbsJE4iN3P1adC99u9eXec+alEdjwtmSdJym/tcET+Jlpd1/PxnCGv9xAyLxoyrx LbSiTlqqqlMnyr9LpivGAYVpbyvhmSUCfJnZJXvzo7q3Jm9SUo5a9UZZQoDF6HmPUcwe 4OHSJewlkMpIOPyvTg/X+TShv6YHRlxRVzG30= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Icedove/3.1.11 In-Reply-To: <20110803170406.GP29562@port70.net> Xref: news.gmane.org gmane.linux.lib.musl.general:229 Archived-At: On 08/03/2011 07:04 PM, Szabolcs Nagy wrote: > i've reported these on irc, but luka was not there > so before i forget: > > alloc.c:127: WEXITSTAUS(stat) used after !WIFEXITED(stat) > > alloc.c should include signal.h (it uses sigaction) > > alloc.c does not compile with glibc here > it seems _POSIX_C_SOURCE is not enough for > glibc to have SA_NODEFER in signal.h > i guess that's a glibc bug.. Thanks for the bug, Szabolcs. I'll correct it, and also add the header. Not sure why you get an error for SA_NODEFER though. It compiles for me just fine with gcc version 4.6.1 (Debian 4.6.1-5) . Note that alloc.c still crashes. I didn't know why yet ( possibly something very bad ;-) ). Same for setuid.c, which hangs. If you could find the reason for those two bugs, that would be awesome and I'd be very grateful. If not, I'll do it once I finish this darned generator. > There's a difference for scanf, but not for printf, and the convention > is to use %d with printf. > > Alexander Well it is used more, I don't know about a convention... I do like %i better (though I was taught %d - hence the omissions). The reason why I like %i is that it implies the integer type. And that's what i have in alloc.c. If you want me to change all %i to %d across all files, i can do that :-/ Luka