From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/366 Path: news.gmane.org!not-for-mail From: =?UTF-8?B?THVrYSBNYXLEjWV0acSH?= Newsgroups: gmane.linux.lib.musl.general Subject: Re: cluts makefiles Date: Tue, 09 Aug 2011 17:48:42 +0200 Message-ID: <4E4156DA.1060107@gmail.com> References: <20110809113045.GA12614@albatros> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1312905070 31956 80.91.229.12 (9 Aug 2011 15:51:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 9 Aug 2011 15:51:10 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-367-gllmg-musl=m.gmane.org@lists.openwall.com Tue Aug 09 17:51:04 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Qqoa6-0008DH-7L for gllmg-musl@lo.gmane.org; Tue, 09 Aug 2011 17:51:02 +0200 Original-Received: (qmail 23757 invoked by uid 550); 9 Aug 2011 15:51:01 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 23749 invoked from network); 9 Aug 2011 15:51:01 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=0tUCCkTyXKjhySCCEBlFtNuKDozQl2aF0uc2UA19VWs=; b=ccHHTCGx54o9Sg1Ys0A1o07G8ko67M9YapVf1zgwFqqyfVZIP6UTHi8+BDa9zTBlPt WKpNK9ilT41uwOK/QP9cikqANm7V+EAxLg4R2kdcQ5AOIG/awOFDoaTd8gqnRgS4KbQP F1XiNC7Z54m1wZ0y0jf59A3NBLo4k4La9apu4= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Icedove/3.1.11 In-Reply-To: <20110809113045.GA12614@albatros> Xref: news.gmane.org gmane.linux.lib.musl.general:366 Archived-At: On 08/09/2011 01:30 PM, Vasiliy Kulikov wrote: > Hi, > > This is a patch to enhance musl building things. > > 1) Divided a single Makefile to the cluts, tests/, compile flags. > > 2) Used gcc's ability to identify dependencies. Do others free compilers support nr 2? > Unrelated things: > > include "sequence.c" is weird :) It's better to use .h with > declarations and .c files which build into .o. It's an ad-hoc dir structure, therefore suboptimal. I'll add prototypes and other declarations into .h some day. > With glibc: > > a) _SVID_SOURCE is needed for alphasort. Maybe older glibc needed it (I get no warnings). I'm not sure it warrants an inclusion (it's SUSv4). > b) SA_NODEFER is undefined in all .c. It should be defined in signal.h. Alexander had problems with this. Trying to apply the patch that you wrote told me you're missing an _XOPEN_SOURCE flag I've relatively recently added to the Make-file on Rich's incentive, so perhaps you could should try that. If it's an old kernel version instead, necessary modifications would be more extensive, involving unblocking when entering the handler (sigprocmask?), removing SA_NODEFERs, using sig*jmp, and perhaps more in some cases. > diff --git a/Makefile b/Makefile Having made dirs a and b (both from the same repo dir), I tried `patch -p0 < yourpatch`, and got: Hunk #1 FAILED at 7. 1 out of 1 hunk FAILED -- saving rejects to file a/Makefile.rej patching file b/defines.mk patching file b/tests/Makefile I tried to replace the offending line with: -CFLAGS = -std=c99 -D_XOPEN_SOURCE=700 -D_POSIX_C_SOURCE=200809L -Wall -Wextra -O2 but somehow the error message persists. Is there something I'm missing? Thanks, Luka