From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/388 Path: news.gmane.org!not-for-mail From: =?UTF-8?B?THVrYSBNYXLEjWV0acSH?= Newsgroups: gmane.linux.lib.musl.general Subject: Re: New daily reports - nothing Date: Wed, 10 Aug 2011 19:21:59 +0200 Message-ID: <4E42BE37.4030805@gmail.com> References: <4E3A79B2.8090204@gmail.com> <4E3B331E.7050502@gmail.com> <4E3CC5AC.3070404@gmail.com> <4E3DFB5D.8040008@gmail.com> <20110807073224.GG132@brightrain.aerifal.cx> <4E3F10C7.4060601@gmail.com> <4E40A33F.7090804@gmail.com> <4E41E020.7020109@gmail.com> <20110810045933.GW132@brightrain.aerifal.cx> <4E427D34.4000905@gmail.com> <20110810142500.GX132@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------010207090005000203040605" X-Trace: dough.gmane.org 1312997067 31787 80.91.229.12 (10 Aug 2011 17:24:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 10 Aug 2011 17:24:27 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-389-gllmg-musl=m.gmane.org@lists.openwall.com Wed Aug 10 19:24:22 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QrCVx-0001po-R2 for gllmg-musl@lo.gmane.org; Wed, 10 Aug 2011 19:24:21 +0200 Original-Received: (qmail 1877 invoked by uid 550); 10 Aug 2011 17:24:21 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 1869 invoked from network); 10 Aug 2011 17:24:21 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=QXxxnZDOQBCfAQDvV9clmMBipA/UqgMFoD2tswGYpXk=; b=DTeleht2elkUPBrlw61HTW9BVneOjyZzbp7kgJpnZXzpYB7YJ2akZZ2jvZUJ9xSZJP C7iiGB/3ultZDHwg2OVCaIHBKRxihkw7XYZzWVUgotAz4VnroJ2uA0vyPRo6R5VmgM8f XTWmCXru7RhB1iH3e+dge55j/PZtjOchTYM0I= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110626 Icedove/3.1.11 In-Reply-To: <20110810142500.GX132@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:388 Archived-At: This is a multi-part message in MIME format. --------------010207090005000203040605 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08/10/2011 04:25 PM, Rich Felker wrote: >> Wait. I've removed sqrtl dependency from alloc.c (I think I > This kind of thing (not making tests depend on completely unrelated > functionality) is the most important since it also relates to > correctness (we don't want bugs in functionality X to impact the > results of tests for functionality Y). I thought I used sqrtl there rather cunningly there: Now it just does calloc(8, BIG/8+1), but then what it did was ~calloc(√BIG, √BIG). My reasoning was: If BIG/8 was judged to be too long by the implementation (like yours), the former would fails by default, whereas in the latter case, it still only fails if the implementation mishandles products of the multiplication. I'm aware of the problem of dependencies though - that's why I'm documenting them. >> committed that, not sure), but does this mean you also want me to >> comment out monetary.h header, and its function's test from buf.c? > [...] configure script [...] > for now it might be the best to have a simple #ifdef so this test > could be disabled from the makefile settings. K Luka --------------010207090005000203040605 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit On 08/10/2011 04:25 PM, Rich Felker wrote:
Wait. I've removed sqrtl dependency from alloc.c (I think I

This kind of thing (not making tests depend on completely unrelated
functionality) is the most important since it also relates to
correctness (we don't want bugs in functionality X to impact the
results of tests for functionality Y).

I thought I used sqrtl there rather cunningly there: Now it just does calloc(8, BIG/8+1), but then what it did was ~calloc(√BIG, √BIG). My reasoning was: If BIG/8 was judged to be too long by the implementation (like yours), the former would fails by default, whereas in the latter case, it still only fails if the implementation mishandles products of the multiplication. I'm aware of the problem of dependencies though - that's why I'm documenting them.

committed that, not sure), but does this mean you also want me to
comment out monetary.h header, and its function's test from buf.c?
[...] configure script [...]
for now it might be the best to have a simple #ifdef so this test
could be disabled from the makefile settings.

K
Luka
--------------010207090005000203040605--