From: Eric Blake <eblake@redhat.com>
To: Rich Felker <dalias@aerifal.cx>
Cc: bug-gnulib@gnu.org, Isaac Dunham <idunham@lavabit.com>,
Paul Eggert <eggert@cs.ucla.edu>,
musl@lists.openwall.com, Reuben Thomas <rrt@sc3d.org>
Subject: Re: [musl] Re: musl bugs found through gnulib
Date: Tue, 19 Jun 2012 22:10:11 -0600 [thread overview]
Message-ID: <4FE14D23.60901@redhat.com> (raw)
In-Reply-To: <20120620030445.GU163@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 3678 bytes --]
On 06/19/2012 09:04 PM, Rich Felker wrote:
>> Replacement of duplocale, because of
>> checking whether duplocale(LC_GLOBAL_LOCALE) works... no
>
> POSIX does not specify any use of LC_GLOBAL_LOCALE except as an
> argument to uselocale. Is there a reason it's needed? Perhaps more
> importantly, is the replacement when libc doesn't provide this
> functionality bloated/painful?
Unfortunately, you are out of date. POSIX _does_ require
duplocale(LC_GLOBAL_LOCALE) to work:
http://austingroupbugs.net/view.php?id=301
If the locobj argument is LC_GLOBAL_LOCALE, duplocale() shall
create a new locale object containing a copy of the global locale
determined by the setlocale() function.
The behavior is undefined if the locobj argument is not a valid
locale object handle.
After line 24978 add a new paragraph to APPLICATION USAGE:
The duplocale() function can also be used in conjunction with
uselocale((locale_t)0). This returns the locale in effect for
the calling thread, but can have the value LC_GLOBAL_LOCALE.
Passing LC_GLOBAL_LOCALE to functions such as isalnum_l()
results in undefined behavior, but applications can convert
it into a usable locale object by using duplocale().
>> test-fcntl.c:382: assertion failed
>> FAIL: test-fcntl
>
> This is caused by the fact that the F_GETOWN fcntl on Linux is broken;
> there's no way to distinguish error returns from non-error negative
> return values. So we never set errno when calling F_GETOWN and assume
> the return value is not an error. There's a new-ish Linux-specific
> F_GETOWN_EX we could use when it's available, but the fallback code
> would still fail just like it does now, because it's a fundamental
> limitation in the API.
Yes, Linux 2.6.32 introduced F_GETOWN_EX for precisely this reason, and
you should be using it.
>> test-grantpt.c:34: assertion failed
>> FAIL: test-grantpt
>
> This is an invalid test. POSIX specifies this function "may fail", not
> "shall fail", and since the function is inherently a no-op, it would
> be idiotic to make it perform a syscall to check the validity of the
> file descriptor...
This is one of the cases where gnulib prefers to emulate the shall fail
semantics of glibc, as they are more useful to program around.
>> test-ptsname_r.c:118: assertion failed
>> FAIL: test-ptsname_r
>
> It's testing that ptsname_r both sets errno and returns the error
> code, and that they're the same. Since this function is nonstandard,
> there's no spec for it, so perhaps this is desirable; I was assuming
> it should return -1 on failure.
There _is_ a proposed standard for it now:
http://austingroupbugs.net/view.php?id=508
which requires only the return value to be 0 or an errno value, and not
that errno be set. gnulib should only be checking for a valid return value.
>
>> test-strerror_r.c:118: assertion failed
>> FAIL: test-strerror_r
>
> This test is looking for a null terminator at the n-1 position of the
> buffer if strerror_r fails with ERANGE (buffer too small). I don't see
> anywhere the function is specified to write to the buffer AT ALL on
> failure, so this test seems invalid.
This is a case where POSIX is rather weak, but where quality of
implementation demands that the most useful interface is one that
provides the most information back to the user. glibc had a number of
bugs that were fixed in this area to improve QoI, and gnulib now prefers
to rely on those improvements.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-06-20 4:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120609230541.47eac2de@newbook>
[not found] ` <4FD55156.7050302@cs.ucla.edu>
[not found] ` <20120611182202.1ee4d019@newbook>
2012-06-17 22:49 ` Bruno Haible
2012-06-17 23:54 ` Rich Felker
2012-06-18 8:21 ` Szabolcs Nagy
2012-06-18 13:02 ` John Spencer
2012-06-18 14:55 ` Rich Felker
2012-06-18 15:26 ` Szabolcs Nagy
2012-06-18 16:00 ` Rich Felker
2012-06-19 13:26 ` John Spencer
2012-06-18 0:16 ` [musl] " idunham
2012-06-19 0:11 ` Rich Felker
2012-06-19 2:07 ` [musl] " Eric Blake
2012-06-19 2:52 ` Rich Felker
2012-06-19 11:03 ` musl, fdopen test Bruno Haible
2012-06-19 11:09 ` Jim Meyering
2012-06-20 20:52 ` Bruno Haible
2012-06-19 10:45 ` musl, printf out-of-memory test Bruno Haible
2012-06-19 19:16 ` Rich Felker
2012-06-19 20:04 ` Bruno Haible
2012-06-19 20:08 ` Rich Felker
2012-06-19 21:17 ` Bruno Haible
2012-06-20 1:52 ` Rich Felker
2012-06-20 7:30 ` Szabolcs Nagy
2012-06-20 9:35 ` Bruno Haible
2012-06-20 11:00 ` Jim Meyering
2012-06-21 19:58 ` Tom Tromey
2012-06-20 3:04 ` Re: musl bugs found through gnulib Rich Felker
2012-06-20 4:10 ` Eric Blake [this message]
2012-06-20 13:27 ` Rich Felker
2012-06-20 7:32 ` Szabolcs Nagy
2012-06-22 10:39 ` grantpt test Bruno Haible
2012-07-02 22:33 ` [musl] Re: musl bugs found through gnulib Pádraig Brady
2012-06-20 19:28 ` Rich Felker
2012-06-21 2:21 ` Rich Felker
2012-06-21 8:52 ` [musl] " Paul Eggert
2012-06-18 0:05 idunham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE14D23.60901@redhat.com \
--to=eblake@redhat.com \
--cc=bug-gnulib@gnu.org \
--cc=dalias@aerifal.cx \
--cc=eggert@cs.ucla.edu \
--cc=idunham@lavabit.com \
--cc=musl@lists.openwall.com \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).