From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/1251 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?P=E1draig_Brady?= Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.linux.lib.musl.general Subject: Re: [musl] Re: musl bugs found through gnulib Date: Tue, 03 Jul 2012 00:33:14 +0200 Message-ID: <4FF221AA.5070700@draigBrady.com> References: <20120609230541.47eac2de@newbook> <4FD55156.7050302@cs.ucla.edu> <20120611182202.1ee4d019@newbook> <12545931.v3ALTEUUx8@linuix> <20120620030445.GU163@brightrain.aerifal.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1341268412 11542 80.91.229.3 (2 Jul 2012 22:33:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 2 Jul 2012 22:33:32 +0000 (UTC) Cc: bug-gnulib@gnu.org, Isaac Dunham , Paul Eggert , musl@lists.openwall.com, Reuben Thomas To: Rich Felker Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Tue Jul 03 00:33:30 2012 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SlpBS-0000ea-70 for gnu-bug-gnulib@m.gmane.org; Tue, 03 Jul 2012 00:33:30 +0200 Original-Received: from localhost ([::1]:55440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlpBR-00079N-40 for gnu-bug-gnulib@m.gmane.org; Mon, 02 Jul 2012 18:33:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlpBN-00078i-AV for bug-gnulib@gnu.org; Mon, 02 Jul 2012 18:33:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SlpBL-0005KU-9F for bug-gnulib@gnu.org; Mon, 02 Jul 2012 18:33:24 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:53451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlpBL-0005KG-1B for bug-gnulib@gnu.org; Mon, 02 Jul 2012 18:33:23 -0400 Original-Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q62MXJGw032410 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 2 Jul 2012 18:33:19 -0400 Original-Received: from [10.3.113.81] (ovpn-113-81.phx2.redhat.com [10.3.113.81]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q62MXF3K021071 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 2 Jul 2012 18:33:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 In-Reply-To: <20120620030445.GU163@brightrain.aerifal.cx> X-Enigmail-Version: 1.3.2 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q62MXJGw032410 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Original-Sender: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Xref: news.gmane.org gmane.comp.lib.gnulib.bugs:31208 gmane.linux.lib.musl.general:1251 Archived-At: On 06/20/2012 05:04 AM, Rich Felker wrote: > Some more updates.. >=20 > On Mon, Jun 18, 2012 at 12:49:44AM +0200, Bruno Haible wrote: >> When I compile all of gnulib, I also get a compilation error >> (may be a musl or a gnulib problem, haven't investigated): >> fsusage.c: In function 'get_fs_usage': >> fsusage.c:222:17: error: storage size of 'fsd' isn't known >> fsusage.c:224:3: warning: implicit declaration of function 'statfs' [-= Wimplicit-function-declaration] >> fsusage.c:222:17: warning: unused variable 'fsd' [-Wunused-variable] >> make[4]: *** [fsusage.o] Error 1 >=20 > This looks like a gnulib problem. On musl, statvfs should get used, > and this code should not even be compiled... Judging from the > comments, it looks like a hard-coded workaround for broken glibc > and/or Linux versions, but the header include seems to be missing in > the workaround case... This is addressed in different ways in these two commits: http://git.sv.gnu.org/gitweb/?p=3Dgnulib.git;a=3Dcommit;h=3Ddefe5737 http://git.sv.gnu.org/gitweb/?p=3Dgnulib.git;a=3Dcommit;h=3D2ab2617e cheers, P=E1draig.