From: Luca Barbato <lu_zero@gentoo.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 1/3] makefile: add silent rules
Date: Fri, 17 Aug 2012 02:10:36 +0200 [thread overview]
Message-ID: <502D8BFC.8030601@gentoo.org> (raw)
In-Reply-To: <30247.132.241.65.36.1345158201.squirrel@lavabit.com>
On 08/17/2012 01:03 AM, idunham@lavabit.com wrote:
>> make V=0 to enable them
>> ---
> Remind me what the _benefit_ is?
An in between make -s and normal make.
> I remember there were several advantages to standard full output, so the
> verdict was that *if* they're added, they get disabled by default.
It is disabled by default.
> While this patch does respect that, I'd like to know whether there's a
> better reason for the added ugliness than "Some folks don't like to see
> what's happening"...
It is faster, you see the warnings w/out useless clutter. You do not
care about seeing what the clean target is doing most of the times and such.
> Also, I note that you're also making a couple other changes: RM, LN, and
> INSTALL...
> Last time, Rich said he didn't see a reason to use $(RM), since rm is
> POSIX. Same can be said of ln/$(LN).
> install appears (per man 1p) to not be POSIX, but is fairly widespread. I
> can see this helping with the occasional broken version of install.
It is used for the quiet machinery
> Patch 3/3 is the most valuable part of the series, I think.
> I can see merging that, and patch 2/3 is trivial.
Indeed, but since I did the work and since at least for few people is
useful I tried to rebase it.
>> -include config.mak
> Umm.... Is this an accident?
Uhm? " -include config.mak" is just that line, see the leading space.
> Axe this part (see above)
> See above.
It is part of the quiet rule.
lu
next prev parent reply other threads:[~2012-08-17 0:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 16:18 Luca Barbato
2012-08-16 16:18 ` [PATCH 2/3] cosmetic: remove trailing whitespace Luca Barbato
2012-08-16 16:18 ` [PATCH 3/3] makefile: split install target Luca Barbato
2012-08-17 23:33 ` Rich Felker
2012-08-16 16:51 ` [PATCH 1/3] makefile: add silent rules orc
2012-08-16 17:05 ` Luca Barbato
2012-08-16 23:03 ` idunham
2012-08-16 23:06 ` Gregor Richards
2012-08-17 0:10 ` Luca Barbato [this message]
2012-08-17 1:21 ` Rich Felker
-- strict thread matches above, loose matches on Subject: below --
2012-06-13 5:22 Build system tweaks Luca Barbato
2012-06-13 5:22 ` [PATCH 1/3] makefile: add silent rules Luca Barbato
2012-06-13 6:27 ` Szabolcs Nagy
2012-06-13 7:46 ` Luca Barbato
2012-06-13 7:34 ` John Spencer
2012-06-13 7:45 ` Luca Barbato
2012-06-13 9:45 ` John Spencer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502D8BFC.8030601@gentoo.org \
--to=lu_zero@gentoo.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).