From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/1763 Path: news.gmane.org!not-for-mail From: musl Newsgroups: gmane.linux.lib.musl.general Subject: Re: ldso : dladdr support Date: Sun, 26 Aug 2012 00:13:58 +0200 Message-ID: <50394E26.6060707@gmail.com> References: <20120811230536.GQ27715@brightrain.aerifal.cx> <20120817053934.GS27715@brightrain.aerifal.cx> <50311776.9040802@gmail.com> <20120820020626.GD27715@brightrain.aerifal.cx> <503233A8.8000604@gmail.com> <50324A60.7040206@gmail.com> <20120823213937.GS27715@brightrain.aerifal.cx> <20120823222113.GT27715@brightrain.aerifal.cx> <50372D59.7090604@gmail.com> <20120824183850.GH27715@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1345932856 10299 80.91.229.3 (25 Aug 2012 22:14:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Aug 2012 22:14:16 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-1764-gllmg-musl=m.gmane.org@lists.openwall.com Sun Aug 26 00:14:17 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1T5OcR-0005Rl-MJ for gllmg-musl@plane.gmane.org; Sun, 26 Aug 2012 00:14:15 +0200 Original-Received: (qmail 13594 invoked by uid 550); 25 Aug 2012 22:14:13 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 13586 invoked from network); 25 Aug 2012 22:14:13 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=GJQldiU/SOfWeHDZGK4u0q40CRhTCKSM5JD7XpHmLF4=; b=CBZVuGuSZXaoBnz+wmw1s11Jvzg8gLQhisP08NU7MWXV8HMO1LUiX8pVrSY3SA+MGO Vka4tCNnpC7CGZVld/3Olmpgso/A1uZ72Tq640tEuGGozmI8UnCjz/ocwyirCCtevnYF liDPeMRvJ1AigbEBToye44amtP8tV7BboZOXzzD9+HcwYW5dxdbB5b4A9kxyh8NRxetk i7mal/OELCTHY79TDxlgvrObIBSK8EoyDLOAn5tNapk20YeEc/tUzu1HfUSVU9Aht/Kt gEz4ZwGiuJ2VYx8zbMFqbE7RnVSeOJ6ourJTPmRIynZh1GLwFIqUS3bPEA7zsK6/s9sM MNuQ== User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 In-Reply-To: <20120824183850.GH27715@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:1763 Archived-At: On 24/08/2012 20:38, Rich Felker wrote: > On Fri, Aug 24, 2012 at 09:29:29AM +0200, musl wrote: >> I tested it and it works well. > Is there anything I changed that you think might be better done a > different way? > >> My tests are based on small libs (with a small set of shared symbols). >> I mixed libs with gnu hash and sysv hash. >> Tried to resolve symbols via dlsym. >> >> Have you tested it on big libraries ? > No, just very minimal testing. > >> Do you want me to do some specific tests ? > Actually, the main thing I'm interested in is whether the bloom filter > is ever beneficial. I took it out trying to streamline the code and > shaved about 8% off the lookup time for symbols in the main program, > but I didn't investigate how the change affects symbols not found in > the first file searched. Would you be interested in running some tests > to determine if it might be useful to try adding it back? > > Since it seems to be working/non-broken right now, I'll probably go > ahead and commit soon unless you find a major problem I've overlooked. > Then we can work on improving it once it's in the repo. I executed your test program (gnuhash) with and without bloom filter test, and I get pretty much the same results in both cases if the symbol is defined. What compiler option did you use to compile gnuhash.c ? I also tried to search for a missing symbol and the version with bloom filter is 3% faster. I'll do more tests with bigger libs and different linker optimizations (some linker optims change the number of buckets in the hash table => less entries per hash chains => faster search in case there's no valid entry for a given name). > > Rich