From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/2169
Path: news.gmane.org!not-for-mail
From: Abdoulaye Walsimou GAYE <awg@embtoolkit.org>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: [PATCH 3/4] Import BSD functions defined in <netinet/ether.h>
 from NetBSD
Date: Sun, 21 Oct 2012 02:40:16 +0200
Message-ID: <50834470.2030502@embtoolkit.org>
References: <1350764145-10305-1-git-send-email-awg@embtoolkit.org>    <1350764145-10305-4-git-send-email-awg@embtoolkit.org> <3016.50.0.224.253.1350776220.squirrel@lavabit.com>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Trace: ger.gmane.org 1350780024 5081 80.91.229.3 (21 Oct 2012 00:40:24 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Sun, 21 Oct 2012 00:40:24 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-2170-gllmg-musl=m.gmane.org@lists.openwall.com Sun Oct 21 02:40:32 2012
Return-path: <musl-return-2170-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@plane.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-2170-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1TPjai-0005Rm-As
	for gllmg-musl@plane.gmane.org; Sun, 21 Oct 2012 02:40:32 +0200
Original-Received: (qmail 28176 invoked by uid 550); 21 Oct 2012 00:40:24 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 28167 invoked from network); 21 Oct 2012 00:40:24 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121011 Thunderbird/16.0.1
In-Reply-To: <3016.50.0.224.253.1350776220.squirrel@lavabit.com>
Xref: news.gmane.org gmane.linux.lib.musl.general:2169
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/2169>

On 10/21/2012 01:37 AM, idunham@lavabit.com wrote:
>> +#ifndef _NETINET_ETHER_H
>> +#define _NETINET_ETHER_H
>> +
>> +#include <sys/cdefs.h>
>> +__BEGIN_DECLS
> musl does not do nested includes unless *necessary*, nor do we define
> macros unless it simplifies the code significantly.
> This detail speeds up compilation significantly.
>
> #ifdef __cplusplus
> extern "C" {
> #endif
>
> is NOT something that obscures the code, and it certainly isn't worth
> adding another nested include.
>
>> +char	*ether_ntoa(const struct ether_addr *);
>> +struct 	ether_addr *ether_aton(const char *);
>> +int	ether_ntohost(char *, const struct ether_addr *);
>> +int	ether_hostton(const char *, struct ether_addr *);
>> +int	ether_line(const char *, struct ether_addr *, char *);
>> +__END_DECLS
> Make that
> #ifdef __cplusplus
> }
> #endif
>
>> +#endif /* !_NETINET_ETHER_H */
> No comments in headers, and certainly not this trivial.
>
>

I see, I will send another patch!

Cheers,
AWG