From: John Spencer <maillist-musl@barfooze.de>
To: musl@lists.openwall.com
Subject: Re: [PATCH 4/4] <netinet/ether.h>: Add GNU extensions ether_ntoa_r() and ether_aton_r()
Date: Sun, 21 Oct 2012 02:46:01 +0200 [thread overview]
Message-ID: <508345C9.2060608@barfooze.de> (raw)
In-Reply-To: <5083454D.7010403@embtoolkit.org>
On 10/21/2012 02:43 AM, Abdoulaye Walsimou GAYE wrote:
> On 10/21/2012 01:53 AM, Rich Felker wrote:
>> On Sat, Oct 20, 2012 at 10:15:45PM +0200, Abdoulaye Walsimou Gaye wrote:
>>> +struct ether_addr *ether_aton_r(const char *s, struct ether_addr *n)
>>> +{
>>> + unsigned int i[6];
>>> + int sz;
>>> +
>>> + assert(s != NULL);
>>> + assert(n != NULL);
>>> +
>>> + sz = sscanf(s, " %x:%x:%x:%x:%x:%x ",
>>> + &i[0], &i[1], &i[2], &i[3], &i[4], &i[5]);
>>> +
>>> + if (sz == 6) {
>>> + n->ether_addr_octet[0] = (unsigned char)i[0];
>>> + n->ether_addr_octet[1] = (unsigned char)i[1];
>>> + n->ether_addr_octet[2] = (unsigned char)i[2];
>>> + n->ether_addr_octet[3] = (unsigned char)i[3];
>>> + n->ether_addr_octet[4] = (unsigned char)i[4];
>>> + n->ether_addr_octet[5] = (unsigned char)i[5];
>>> + return n;
>> I think this code could be greatly simplified using %hhx as the format
>> instead of %x, but either way it's lacking any error checking and
>> accepts lots of inputs that probably should not be accepted. Is this
>> an issue?
>>
>> Rich
>>
>>
>
> As I said, the code is almost copied "AS IS" from NetBSD to have
> <netinet/ether.h> features,
> feel free to amend it.
s/amend/reject/
prev parent reply other threads:[~2012-10-21 0:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 20:15 [PATCH 0/4] Import <netinet/ether.h> features from NetBSD Abdoulaye Walsimou Gaye
2012-10-20 20:15 ` [PATCH 1/4] Build system: give ability to install lib/crt*.o files separately Abdoulaye Walsimou Gaye
2012-10-20 23:49 ` Rich Felker
2012-10-20 20:15 ` [PATCH 2/4] Add basic sys/cdefs.h found on most unix Abdoulaye Walsimou Gaye
2012-10-20 23:18 ` Isaac Dunham
2012-10-20 23:38 ` Abdoulaye Walsimou GAYE
2012-10-20 23:38 ` Rich Felker
2012-10-21 0:13 ` Abdoulaye Walsimou GAYE
2012-10-21 0:11 ` Rich Felker
2012-10-21 0:38 ` Abdoulaye Walsimou GAYE
2012-10-21 0:39 ` John Spencer
2012-10-21 1:21 ` John Spencer
2012-10-20 23:50 ` Isaac Dunham
2012-10-20 23:44 ` Rich Felker
2012-10-20 20:15 ` [PATCH 3/4] Import BSD functions defined in <netinet/ether.h> from NetBSD Abdoulaye Walsimou Gaye
2012-10-20 23:37 ` idunham
2012-10-21 0:40 ` Abdoulaye Walsimou GAYE
2012-10-21 0:42 ` John Spencer
2012-10-21 0:41 ` Rich Felker
2012-10-21 0:52 ` Abdoulaye Walsimou GAYE
2012-10-21 0:48 ` Rich Felker
2012-10-21 0:57 ` John Spencer
2012-10-21 0:53 ` Rich Felker
2012-10-20 20:15 ` [PATCH 4/4] <netinet/ether.h>: Add GNU extensions ether_ntoa_r() and ether_aton_r() Abdoulaye Walsimou Gaye
2012-10-20 23:53 ` Rich Felker
2012-10-21 0:43 ` Abdoulaye Walsimou GAYE
2012-10-21 0:46 ` John Spencer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508345C9.2060608@barfooze.de \
--to=maillist-musl@barfooze.de \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).