From: John Spencer <maillist-musl@barfooze.de>
To: musl@lists.openwall.com
Subject: Re: strcasestr.c
Date: Wed, 20 Feb 2013 23:28:31 +0100 [thread overview]
Message-ID: <51254E0F.7010206@barfooze.de> (raw)
In-Reply-To: <20130217190452.GH20323@brightrain.aerifal.cx>
On 02/17/2013 08:04 PM, Rich Felker wrote:
> On Thu, Feb 14, 2013 at 10:23:49AM -0500, Rich Felker wrote:
>> On Thu, Feb 14, 2013 at 09:59:56AM -0500, Todd C. Miller wrote:
>>> When investigating using the musl strstr.c ofr OpenBSD I noticed
>>> that musl only has a stub for strcasestr() that calls strstr().
according to git log, this function dates back to the very first musl
commit ever...
> Since strcasestr is nonstandard and not clearly specified,
it's so non-standard that even nobody uses it.
i looked up the usage of the function in codesearch.debian.net, and the
only *user* (from all ~20K debian packages) of the function is gnu wget.
every other occurence of the function is from gnulib embedded into other
packages.
so the current status is: gnulib includes the function, but nobody
besides gnu wget uses it.
> Comments from anybody else?
given the above findings, we can just leave the function as-is (plus a
comment that nobody uses it anyway) or remove it entirely.
in any case it doesnt make sense to put much work and especially much
code into it.
if it's gonna be implemented "correctly" at all, it should be as slim as
possible, in the order of 3-5 LOC.
next prev parent reply other threads:[~2013-02-20 22:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 14:59 strcasestr.c Todd C. Miller
2013-02-14 15:23 ` strcasestr.c Rich Felker
2013-02-17 19:04 ` strcasestr.c Rich Felker
2013-02-20 22:28 ` John Spencer [this message]
2013-02-20 23:56 ` strcasestr.c Szabolcs Nagy
2013-02-21 1:03 ` strcasestr.c Rich Felker
2013-02-21 1:30 ` strcasestr.c Kurt H Maier
2013-02-21 1:34 ` strcasestr.c Rich Felker
2013-02-21 6:18 ` strcasestr.c Isaac Dunham
2013-02-21 20:00 ` strcasestr.c John Spencer
2013-02-21 20:13 ` strcasestr.c Szabolcs Nagy
2013-02-22 5:20 ` strcasestr.c Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51254E0F.7010206@barfooze.de \
--to=maillist-musl@barfooze.de \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).