From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/2819 Path: news.gmane.org!not-for-mail From: John Spencer Newsgroups: gmane.linux.lib.musl.general Subject: Re: strcasestr.c Date: Wed, 20 Feb 2013 23:28:31 +0100 Message-ID: <51254E0F.7010206@barfooze.de> References: <201302141459.r1EExuU3024259@core.courtesan.com> <20130214152349.GA20323@brightrain.aerifal.cx> <20130217190452.GH20323@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1361399347 19766 80.91.229.3 (20 Feb 2013 22:29:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Feb 2013 22:29:07 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-2820-gllmg-musl=m.gmane.org@lists.openwall.com Wed Feb 20 23:29:30 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1U8IAL-0003ZN-RC for gllmg-musl@plane.gmane.org; Wed, 20 Feb 2013 23:29:30 +0100 Original-Received: (qmail 3731 invoked by uid 550); 20 Feb 2013 22:29:09 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 3723 invoked from network); 20 Feb 2013 22:29:09 -0000 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Mail/1.0 In-Reply-To: <20130217190452.GH20323@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:2819 Archived-At: On 02/17/2013 08:04 PM, Rich Felker wrote: > On Thu, Feb 14, 2013 at 10:23:49AM -0500, Rich Felker wrote: >> On Thu, Feb 14, 2013 at 09:59:56AM -0500, Todd C. Miller wrote: >>> When investigating using the musl strstr.c ofr OpenBSD I noticed >>> that musl only has a stub for strcasestr() that calls strstr(). according to git log, this function dates back to the very first musl commit ever... > Since strcasestr is nonstandard and not clearly specified, it's so non-standard that even nobody uses it. i looked up the usage of the function in codesearch.debian.net, and the only *user* (from all ~20K debian packages) of the function is gnu wget. every other occurence of the function is from gnulib embedded into other packages. so the current status is: gnulib includes the function, but nobody besides gnu wget uses it. > Comments from anybody else? given the above findings, we can just leave the function as-is (plus a comment that nobody uses it anyway) or remove it entirely. in any case it doesnt make sense to put much work and especially much code into it. if it's gonna be implemented "correctly" at all, it should be as slim as possible, in the order of 3-5 LOC.