From: John Spencer <maillist-musl@barfooze.de>
To: musl@lists.openwall.com
Subject: Re: strcasestr.c
Date: Thu, 21 Feb 2013 21:00:27 +0100 [thread overview]
Message-ID: <51267CDB.3030607@barfooze.de> (raw)
In-Reply-To: <20130220221827.6ee8a6ff.idunham@lavabit.com>
On 02/21/2013 07:18 AM, Isaac Dunham wrote:
> On Wed, 20 Feb 2013 20:03:28 -0500
> Rich Felker<dalias@aerifal.cx> wrote:
>>>> Since strcasestr is nonstandard and not clearly specified,
>>> it's so non-standard that even nobody uses it.
>>> i looked up the usage of the function in codesearch.debian.net, and
>>> the only *user* (from all ~20K debian packages) of the function is
>>> gnu wget.
>> Are you sure this search was correct? IIRC there were more...
i just checked again, and according to debian codesearch this is indeed
the only call.
> A quick check here indicates that busybox, mutt, git, midnight commander, sylpheed, foomatic-rip, elinks, and a couple libraries use it.
> Busycox uses it in grep and for checking passwords (see libbb/obscure.c).
interesting findings. i can confirm that busybox does indeed use
strcasestr unconditionally, and git seems to use it as well.
so it was probably added to make busybox happy.
i can't really believe that git is not in debian's 18K base packages, so
i can't really explain why this is missing from codesearch results.
>> The other somewhat reasonable option would be removing the function,
>> which would expose breakage in programs that were already using the
>> broken version in musl. I'm mildly against this, but I'd be interested
>> in hearing arguments either way.
> Were the claimed frequency correct, I would want it gone. As it stands, I think that a small but slow version is justifiable. A large one isn't.
*nod*
next prev parent reply other threads:[~2013-02-21 20:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 14:59 strcasestr.c Todd C. Miller
2013-02-14 15:23 ` strcasestr.c Rich Felker
2013-02-17 19:04 ` strcasestr.c Rich Felker
2013-02-20 22:28 ` strcasestr.c John Spencer
2013-02-20 23:56 ` strcasestr.c Szabolcs Nagy
2013-02-21 1:03 ` strcasestr.c Rich Felker
2013-02-21 1:30 ` strcasestr.c Kurt H Maier
2013-02-21 1:34 ` strcasestr.c Rich Felker
2013-02-21 6:18 ` strcasestr.c Isaac Dunham
2013-02-21 20:00 ` John Spencer [this message]
2013-02-21 20:13 ` strcasestr.c Szabolcs Nagy
2013-02-22 5:20 ` strcasestr.c Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51267CDB.3030607@barfooze.de \
--to=maillist-musl@barfooze.de \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).