From: John Spencer <maillist-musl@barfooze.de>
To: musl@lists.openwall.com
Cc: Richard Pennington <rich@pennware.com>
Subject: Re: repeated definitions in /arch/mips/bits/syscall.h
Date: Sun, 17 Mar 2013 08:01:57 +0100 [thread overview]
Message-ID: <51456A65.6010902@barfooze.de> (raw)
In-Reply-To: <20130317045729.GL20323@brightrain.aerifal.cx>
On 03/17/2013 05:57 AM, Rich Felker wrote:
> On Sun, Mar 17, 2013 at 12:26:13AM -0400, Zvi Gilboa wrote:
>> Greetings,
>>
>> It looks like the above file contains multiple identical definitions
>> of the same constant. For instance, __NR_fallocate is defined three
>> times as 4320, specifically in lines 320, 321, and 344. Is there a
>> reason behind that? Using gcc this seems to be harmless, but
>> still...
> Yes, something looks amiss. I wonder if it was a result of flawed
> search-and-replace or other automated operations. I can look into it.
> Anybody else know?
according to git log, it dates back to the first check-in of rdp's sources.
there's an entire block of ~15 duplicated syscalls, starting with the
fallocate one.
(it's also replicated down there in the SYS_ section).
cc'ing rdp, maybe he knows...
in any case, that block can be safely removed in both sections.
prev parent reply other threads:[~2013-03-17 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-17 4:26 Zvi Gilboa
2013-03-17 4:57 ` Rich Felker
2013-03-17 7:01 ` John Spencer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51456A65.6010902@barfooze.de \
--to=maillist-musl@barfooze.de \
--cc=musl@lists.openwall.com \
--cc=rich@pennware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).