From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/2930 Path: news.gmane.org!not-for-mail From: John Spencer Newsgroups: gmane.linux.lib.musl.general Subject: Re: repeated definitions in /arch/mips/bits/syscall.h Date: Sun, 17 Mar 2013 08:01:57 +0100 Message-ID: <51456A65.6010902@barfooze.de> References: <514545E5.1040001@eservices.virginia.edu> <20130317045729.GL20323@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1363503746 23623 80.91.229.3 (17 Mar 2013 07:02:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 Mar 2013 07:02:26 +0000 (UTC) Cc: Richard Pennington To: musl@lists.openwall.com Original-X-From: musl-return-2931-gllmg-musl=m.gmane.org@lists.openwall.com Sun Mar 17 08:02:52 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1UH7cJ-000504-6w for gllmg-musl@plane.gmane.org; Sun, 17 Mar 2013 08:02:51 +0100 Original-Received: (qmail 14200 invoked by uid 550); 17 Mar 2013 07:02:27 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 14192 invoked from network); 17 Mar 2013 07:02:27 -0000 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Mail/1.0 In-Reply-To: <20130317045729.GL20323@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:2930 Archived-At: On 03/17/2013 05:57 AM, Rich Felker wrote: > On Sun, Mar 17, 2013 at 12:26:13AM -0400, Zvi Gilboa wrote: >> Greetings, >> >> It looks like the above file contains multiple identical definitions >> of the same constant. For instance, __NR_fallocate is defined three >> times as 4320, specifically in lines 320, 321, and 344. Is there a >> reason behind that? Using gcc this seems to be harmless, but >> still... > Yes, something looks amiss. I wonder if it was a result of flawed > search-and-replace or other automated operations. I can look into it. > Anybody else know? according to git log, it dates back to the first check-in of rdp's sources. there's an entire block of ~15 duplicated syscalls, starting with the fallocate one. (it's also replicated down there in the SYS_ section). cc'ing rdp, maybe he knows... in any case, that block can be safely removed in both sections.