From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/4291 Path: news.gmane.org!not-for-mail From: Laurent Bercot Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Add support for leap seconds in zoneinfo files Date: Wed, 27 Nov 2013 20:33:57 +0000 Message-ID: <52965735.9070409@skarnet.org> References: <5294EE35.8040603@skarnet.org> <20131126233212.GE24286@brightrain.aerifal.cx> <529570BB.2060804@skarnet.org> <20131127042550.GI24286@brightrain.aerifal.cx> <529588D8.3020006@skarnet.org> <20131127184307.GN1685@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1385584437 10198 80.91.229.3 (27 Nov 2013 20:33:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Nov 2013 20:33:57 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-4295-gllmg-musl=m.gmane.org@lists.openwall.com Wed Nov 27 21:34:03 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1VlloA-0005M5-P8 for gllmg-musl@plane.gmane.org; Wed, 27 Nov 2013 21:34:02 +0100 Original-Received: (qmail 28656 invoked by uid 550); 27 Nov 2013 20:34:01 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 28634 invoked from network); 27 Nov 2013 20:34:01 -0000 X-SourceIP: 89.100.252.69 User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 In-Reply-To: <20131127184307.GN1685@port70.net> Xref: news.gmane.org gmane.linux.lib.musl.general:4291 Archived-At: > i think with the leap second patch localtime is no longer correct: > > __secs_to_tm((long long)*t - tm->__tm_gmtoff, tm) < 0 Ah, good catch, the correction shoud also apply to the time given to __secs_to_zone(). I'll fix that in the next version of the patch. -- Laurent