From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/4473 Path: news.gmane.org!not-for-mail From: Rob Landley Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: libgcc --disable-shared test case Date: Sat, 11 Jan 2014 20:35:50 -0600 Message-ID: <52D1FF86.80800@landley.net> References: <20131017060913.GA1957@brightrain.aerifal.cx> <1389462032.1176.18@driftwood> <20140111215106.GV24286@brightrain.aerifal.cx> <52D1BFE9.6040703@landley.net> <20140111222354.GW24286@brightrain.aerifal.cx> <52D1C7EC.5090908@landley.net> <20140111224509.GX24286@brightrain.aerifal.cx> <52D1D9DF.1010300@barfooze.de> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1389494160 23079 80.91.229.3 (12 Jan 2014 02:36:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 12 Jan 2014 02:36:00 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-4477-gllmg-musl=m.gmane.org@lists.openwall.com Sun Jan 12 03:36:09 2014 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1W2AuF-0005VD-VS for gllmg-musl@plane.gmane.org; Sun, 12 Jan 2014 03:36:08 +0100 Original-Received: (qmail 18163 invoked by uid 550); 12 Jan 2014 02:36:07 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 18155 invoked from network); 12 Jan 2014 02:36:07 -0000 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=pFMsrXsj/20UsMeL7l+S7PoOvzuZfdW+Vs9L5VUnKCw=; b=EYm60kFm7WP5VKFUzPHxIb+ZZfoAVnbL4FH5PIdD7ZP7dKsGjDqjNmpdrpTL9hr2XL fPbjqIpckbVCdmzMNOBpialruScFCKUrdBsHbMUaIN+m2OuC1CgOnnGeT4yo3Y/Kti90 teHH5VwSaG1V8/7ZQu4Ezp1Y0TF2RIT8Yahayb3X09lcdy56NpwkMhBqsZ42DQqEKpU6 e34iIVr+DmVL5Wpvd33xijEETfBngZWssHqLOrPwyfkYHelw7Kg/+aKc5E+GiT5fijBz c0OzspLNM5XGdZF4zWxPYNcUY0s6YvcaD3ukvMqZ+kPBKhy9aRXESRPy78Sv1X9oYoz9 /1NQ== X-Gm-Message-State: ALoCoQk6Jg5XyIMsjUB2jQudS+ujS8v0Sk+b0Oysja4wsVESOJCeK7vRa2PxQPutWLDypO8JNZ+D X-Received: by 10.60.54.168 with SMTP id k8mr1589247oep.56.1389494154470; Sat, 11 Jan 2014 18:35:54 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 In-Reply-To: <52D1D9DF.1010300@barfooze.de> Xref: news.gmane.org gmane.linux.lib.musl.general:4473 Archived-At: On 01/11/14 17:55, John Spencer wrote: > Rich Felker wrote: >> The way to fix it is to find the conditional logic in the gcc build >> system (I forget whether it's in configure, the Makefiles, or the >> headers) that disables use of the visibility attribute when >> --disable-shared is passed, and simply dummy it out so that visibility >> is always used. At one point we discussed on IRC how this could be >> fixed at the GCC level, so I could probably dig something out of IRC >> logs if you want. > > that would be > https://github.com/sabotage-linux/sabotage/blob/36661440192e2ec51531ea81c7866578010f3283/KEEP/gcc-454-libgcc_hidden.patch In 4.2 there is no libgcc/Makefile.in, instead there's a mklibgcc.in generating the file. Given that it's generating a value and assigning it to vis_hide a few lines earlier, I have no idea if the suggested fix (trying to pass through a value from autoconf?) is relevant to this version of the code. The real problem is I have no way to reproduce the failure yet. The comment that it occurs building musl for mips seems useful, I'll try that. But it's kinda hard to fix a failure I've never seen fail... Rob