From: "writeonce@midipix.org" <writeonce@midipix.org>
To: musl@lists.openwall.com
Subject: Re: static musl-based gdb and -fPIC
Date: Mon, 21 Apr 2014 07:16:14 -0400 [thread overview]
Message-ID: <5354FDFE.5030809@midipix.org> (raw)
In-Reply-To: <20140421073347.GB12324@port70.net>
On 04/21/2014 03:33 AM, Szabolcs Nagy wrote:
> * writeonce@midipix.org <writeonce@midipix.org> [2014-04-20 17:39:37 -0400]:
>> For the record: python's Modules/posixmodule.c has a static
>> implementation of posix_close that is incompatible with musl's. My
> yes they define posix_ prefixed symbols for internal use
> which are reserved names for the c implementation when
> any standard headers are included
>
> the next posix standard defines posix_close so this is a
> real collision (and will be an issue with every conformant
> libc), but all the other posix_ symbols are wrong there too
>
>> first take on that was to make python use musl's posix_close, which
>> resulted in a very subtle bug leading to a segmentation fault (not
>> to mention all of those lost hours...) Renaming the module's
>> posix_close to __posix_close solved the problem. The code that
> these functions have nothing to do with libc: they operate on
> python objects
>
> the symbols should be just renamed but your solution is wrong:
> the __ prefix is still in the reserved name space
>
> use s/posix_/pyposix_/ or similar
>
>
Thanks for pointing this out. I guess Py_posix_close would be closest
in spirit to the rest of the python code.
next prev parent reply other threads:[~2014-04-21 11:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 17:03 writeonce
2014-04-20 20:29 ` writeonce
2014-04-20 20:31 ` Rich Felker
2014-04-20 21:39 ` writeonce
2014-04-21 7:33 ` Szabolcs Nagy
2014-04-21 8:21 ` Szabolcs Nagy
2014-04-21 11:16 ` writeonce
2014-04-21 11:16 ` writeonce [this message]
2014-04-29 21:40 ` writeonce
2014-04-30 2:57 ` Rich Felker
2014-04-30 3:26 ` writeonce
2014-04-30 4:07 ` Rich Felker
2014-04-30 4:29 ` Zvi Gilboa
2014-05-22 20:14 ` John Spencer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5354FDFE.5030809@midipix.org \
--to=writeonce@midipix.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).