mailing list of musl libc
 help / color / mirror / code / Atom feed
* [musl] [PATCH] inet_ntop: Fix the IPv6 leading zero sequence compression
@ 2024-06-13 22:59 Jakub Stasiak
  0 siblings, 0 replies; only message in thread
From: Jakub Stasiak @ 2024-06-13 22:59 UTC (permalink / raw)
  To: musl

Per RFC 5952[1]:

    4.2.3.  Choice in Placement of "::"

       (...) When the length of the consecutive 16-bit 0 fields
       are equal (i.e., 2001:db8:0:0:1:0:0:1), the first sequence of zero
       bits MUST be shortened.  For example, 2001:db8::1:0:0:1 is correct

but the implementation put the leading sequence of zeros at a
disadvantage. That's because for example when compressing


the strspn(buf+i, ":0") call returns 6 for the first sequence and 7 for
the second one – the second sequence has the benefit of a leading

Because of that for this IPv6 input


inet_ntop produced


instead of


Changing the condition to require beating the leading sequence by not
one but two characters resolves the issue.

The new behavior is consistent with other implementations I tested
(glibc, Apple libc).

 src/network/inet_ntop.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/network/inet_ntop.c b/src/network/inet_ntop.c
index 4bfef2c557ab..37257cf9d787 100644
--- a/src/network/inet_ntop.c
+++ b/src/network/inet_ntop.c
@@ -34,7 +34,10 @@ const char *inet_ntop(int af, const void *restrict a0, char *restrict s, socklen
 		for (i=best=0, max=2; buf[i]; i++) {
 			if (i && buf[i] != ':') continue;
 			j = strspn(buf+i, ":0");
-			if (j>max) best=i, max=j;
+			// The leading sequence of zeros (best==0) is disadvantaged compared to
+			// sequences elsewhere as it doesn't have a leading colon. One extra
+			// character is required for another sequence to beat it fairly.
+			if (j>max+(best==0)) best=i, max=j;
 		if (max>3) {
 			buf[best] = buf[best+1] = ':';

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-06-13 23:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-13 22:59 [musl] [PATCH] inet_ntop: Fix the IPv6 leading zero sequence compression Jakub Stasiak

Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).