From: John Spencer <maillist-musl@barfooze.de>
To: musl@lists.openwall.com
Cc: Gregor Richards <gr@purdue.edu>
Subject: fixing -fPIE + -fstack-protector-all
Date: Wed, 05 Nov 2014 16:25:03 +0100 [thread overview]
Message-ID: <545A414F.8000407@barfooze.de> (raw)
using -fPIE + -fstack-protector-all is currently broken for a number of
architectures (most notably i386) in the default gcc setup (including
the musl-cross patches), as it depends on a libssp_nonshared.a which
provides __stack_chk_fail_local().
even when gcc's version is built from ssp-local.c and installed via
`make install-target-libssp`, gcc won't use it to link programs compiled
with -fstack-protector[-all].
the reason is that (since we provide the rest of the ssp functionality
in musl) we set gcc_cv_libc_provides_ssp=yes, which, contrary to our
earlier expectations means: "libc provides ssp *and* ssp_nonshared":
(from gcc/gcc.c)
#ifdef TARGET_LIBC_PROVIDES_SSP
#define LINK_SSP_SPEC "%{fstack-protector:}"
#else
#define LINK_SSP_SPEC
"%{fstack-protector|fstack-protector-all:-lssp_nonshared -lssp}"
#endif
so my conclusion is that in order to fix this issue cleanly and get musl
support into upstream, we need to either (on the gcc side) define a new
gcc_cv_libc_provides_ssp_but_not_ssp_nonshared conditional and an
install target that installs only libssp_nonshared but not libssp, and
links only to libssp_nonshared if ssp was used, or somehow get that
symbol (__stack_chk_fail_local()) into musl and linked to binaries in a
way that doesn't require additional library flags on the linker command
line.
in the former case, the above snippet would look like
#ifdef TARGET_LIBC_PROVIDES_SSP
#define LINK_SSP_SPEC "%{fstack-protector:}"
#elif TARGET_LIBC_PROVIDES_SSP_BUT_NOT_SSP_NONSHARED
#define LINK_SSP_SPEC
"%{fstack-protector|fstack-protector-all:-lssp_nonshared}"
#else
#define LINK_SSP_SPEC
"%{fstack-protector|fstack-protector-all:-lssp_nonshared -lssp}"
#endif
--JS
next reply other threads:[~2014-11-05 15:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 15:25 John Spencer [this message]
2014-11-05 15:43 ` Rich Felker
2014-11-05 16:01 ` John Spencer
2014-11-05 16:20 ` Rich Felker
2014-11-06 1:34 ` Andy Lutomirski
2014-11-06 1:44 ` Rich Felker
2014-11-06 11:45 ` Anthony G. Basile
2014-11-06 12:36 ` John Spencer
2014-11-07 12:25 ` Anthony G. Basile
2014-11-07 2:10 ` Andy Lutomirski
2014-11-07 12:16 ` Anthony G. Basile
2014-11-05 16:01 ` Timo Teras
2014-11-06 12:11 ` Anthony G. Basile
2014-11-06 15:43 ` Rich Felker
2014-11-06 12:40 ` John Spencer
2014-11-06 12:47 ` Timo Teras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A414F.8000407@barfooze.de \
--to=maillist-musl@barfooze.de \
--cc=gr@purdue.edu \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).