From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/7488 Path: news.gmane.org!not-for-mail From: Jean-Marc Pigeon Newsgroups: gmane.linux.lib.musl.general Subject: Re: setenv if value=NULL, what say standard? Bug? Date: Thu, 23 Apr 2015 08:58:50 -0400 Message-ID: <5538EC8A.5080206@safe.ca> References: <553837F1.5080808@safe.ca> <55383E43.8010505@skarnet.org> <55384A61.5020001@safe.ca> <20150423021507.GG6817@brightrain.aerifal.cx> <5538740E.1030306@safe.ca> <20150423101039.GC17573@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms010900070701040004020805" X-Trace: ger.gmane.org 1429793961 16516 80.91.229.3 (23 Apr 2015 12:59:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Apr 2015 12:59:21 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-7501-gllmg-musl=m.gmane.org@lists.openwall.com Thu Apr 23 14:59:10 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1YlGij-0008V8-31 for gllmg-musl@m.gmane.org; Thu, 23 Apr 2015 14:59:09 +0200 Original-Received: (qmail 11833 invoked by uid 550); 23 Apr 2015 12:59:07 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 11812 invoked from network); 23 Apr 2015 12:59:06 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0 In-Reply-To: <20150423101039.GC17573@brightrain.aerifal.cx> X-Enigmail-Version: 1.6 X-Clement-Version: 2.6-6.7 X-Clement-ID: <00718-20150423085850-a679d92e> X-Clement-Virus-checker: ClamAV 0.98.4/20365/Wed Apr 22 18:38:41 2015 Xref: news.gmane.org gmane.linux.lib.musl.general:7488 Archived-At: This is a cryptographically signed message in MIME format. --------------ms010900070701040004020805 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello... [..] >>=20 >> As reported, the crashing application is hwclock, >> (util-linux-2.26), this a kind of code in the field for a very >> very long time, >=20 > And it either crashes every time it's run (for a given > configuration, at least) or doesn't. If it does you know during > early testing rather than letting a bug slip through. >=20 >> so the library (glibc and old libc) used for linux over the years >> defined an expected behavior to this "UB". >=20 > No, that was merely a bug in glibc, not a feature. Hmmm... glibc-2.21, setenv.c explicitly check the value NULL condition, so situation is checked, you could object about the way program handle it, but it is not a bug (situation expected and addressed). > Crashing is inevitable on the vast majority of invalid programs.=20 > setenv("TZ", (char *)0xdeadbeef, 1); will almost certainly crash, > and if it doesn't it will likely do something worse. Fully agreed, this is pure garbage, out of spec. library will/must crash (protect the hardware). >=20 >> (:-} why bother to return an error, just crash for all problems >> in open, close, write, etc. just bringing the crashing concept to >> the extreme :-}). >=20 >=20 > int foo(const char *fn) { char buf[2]; strcpy(buf, "hello world, > and goodbye"); In perfect world, strcpy should crash on the spot not going further. this is clearly "out of spec" (a far fetch to be UB). > int fd =3D open(fn ? fn : buf, O_RDONLY); return fd < 0 ? -1 : fd; } - --=20 A bient=F4t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D Jean-Marc Pigeon E-Mail: jmp@safe.ca SAFE Inc. Phone: (514) 493-4280 Clement, 'a kiss solution' to get rid of SPAM (at last) Clement' Home base <"http://www.clement.safe.ca"> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJVOOyKAAoJEAtgwJ4bBQU5E4YP/1G+J2vij9VF34tfZycG3iHO Gs6y2WYsvyVZK66WsnDOOoaBr5h6bJv8pga++6hu/DVPpbXfZpY1ysNKQ63hxP02 1fFA8h1UjDJ4BM/aXHGothjp2kIXVn5CzJKuf2KUrFiR59t9WJu4KDR6/MsbRXTx MsnOS25x+UCo4yQExemTuANAofdrst5mDyXovBdEaEGuGiTZuZri9NvZ8BZGEd4Y v8cX/+UyY3X7UrB1+AAXbMEDs+miibXIGBI6EPPme5sDeVTm3V4kmqgdPu3Q+D00 Mgq6D+uj7Y3Wg8yHfzlVw/wZBYh1KGJNjOXJhKjmBvquCa3SQADAWBPc109J1Iip v6efkBy3b36uWT5xoRtX4Db8+jdUUiVLLj4zRBytgkLokK8imvLlIGa1oBIUYGN8 RzC7Ma0hgHl7Tqxa7awvOfoVgqTWxC6saLmzJ+N8hFy5yg6YJYr+yvLY8fLkRPQM BdNu/YzwFb1gIKDyq+lPtCjvMZVHpfcZMYorcV22N2zyaW7UTqU7BqRLR2mY/ojh Nf8mUZNEsfeSNNHANZa5gixXFfDIQ/8zkZbIbY3XItESjdJft0wBmLBk8t0IJ6nO zexIcNM3NozIZotsL+L47cHoedrYSLp/v2HK5kJ/V638qRGKhxkz9IBbe1UMwOfV 0kG3h7pAHZ5iBchsiQ8G =3DyBbf -----END PGP SIGNATURE----- --------------ms010900070701040004020805 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIMdzCC BjQwggQcoAMCAQICAR4wDQYJKoZIhvcNAQEFBQAwfTELMAkGA1UEBhMCSUwxFjAUBgNVBAoT DVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENlcnRpZmljYXRlIFNp Z25pbmcxKTAnBgNVBAMTIFN0YXJ0Q29tIENlcnRpZmljYXRpb24gQXV0aG9yaXR5MB4XDTA3 MTAyNDIxMDE1NVoXDTE3MTAyNDIxMDE1NVowgYwxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1T dGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWdu aW5nMTgwNgYDVQQDEy9TdGFydENvbSBDbGFzcyAxIFByaW1hcnkgSW50ZXJtZWRpYXRlIENs aWVudCBDQTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMcJg8zOLdgasSmkLhOr lr6KMoOMpohBllVHrdRvEg/q6r8jR+EK75xCGhR8ToREoqe7zM9/UnC6TS2y9UKTpT1v7RSM zR0t6ndl0TWBuUr/UXBhPk+Kmy7bI4yW4urC+y7P3/1/X7U8ocb8VpH/Clt+4iq7nirMcNh6 qJR+xjOhV+VHzQMALuGYn5KZmc1NbJQYclsGkDxDz2UbFqE2+6vIZoL+jb9x4Pa5gNf1TwSD kOkikZB1xtB4ZqtXThaABSONdfmv/Z1pua3FYxnCFmdr/+N2JLKutIxMYqQOJebr/f/h5t95 m4JgrM3Y/w7YX9d7YAL9jvN4SydHsU6n65cCAwEAAaOCAa0wggGpMA8GA1UdEwEB/wQFMAMB Af8wDgYDVR0PAQH/BAQDAgEGMB0GA1UdDgQWBBRTcu2SnODaywFcfH6WNU7y1LhRgjAfBgNV HSMEGDAWgBROC+8apEBbpRdphzDKNGhD0EGu8jBmBggrBgEFBQcBAQRaMFgwJwYIKwYBBQUH MAGGG2h0dHA6Ly9vY3NwLnN0YXJ0c3NsLmNvbS9jYTAtBggrBgEFBQcwAoYhaHR0cDovL3d3 dy5zdGFydHNzbC5jb20vc2ZzY2EuY3J0MFsGA1UdHwRUMFIwJ6AloCOGIWh0dHA6Ly93d3cu c3RhcnRzc2wuY29tL3Nmc2NhLmNybDAnoCWgI4YhaHR0cDovL2NybC5zdGFydHNzbC5jb20v c2ZzY2EuY3JsMIGABgNVHSAEeTB3MHUGCysGAQQBgbU3AQIBMGYwLgYIKwYBBQUHAgEWImh0 dHA6Ly93d3cuc3RhcnRzc2wuY29tL3BvbGljeS5wZGYwNAYIKwYBBQUHAgEWKGh0dHA6Ly93 d3cuc3RhcnRzc2wuY29tL2ludGVybWVkaWF0ZS5wZGYwDQYJKoZIhvcNAQEFBQADggIBAAqD CH14qywGXLhjjF6uHLkjd02hcdh9hrw+VUsv+q1eeQWB21jWj3kJ96AUlPCoEGZ/ynJNScWy 6QMVQjbbMXltUfO4n4bGGdKo3awPWp61tjAFgraLJgDk+DsSvUD6EowjMTNx25GQgyYJ5RPI zKKR9tQW8gGK+2+RHxkUCTbYFnL6kl8Ch507rUdPPipJ9CgJFws3kDS3gOS5WFMxcjO5DwKf KSETEPrHh7p5shuuNktvsv6hxHTLhiMKX893gxdT3XLS9OKmCv87vkINQcNEcIIoFWbP9HOR z9v3vQwR4e3ksLc2JZOAFK+ssS5XMEoznzpihEP0PLc4dCBYjbvSD7kxgDwZ+Aj8Q9PkbvE9 sIPP7ON0fz095HdThKjiVJe6vofq+n6b1NBc8XdrQvBmunwxD5nvtTW4vtN6VY7mUCmxsCie uoBJ9OlqmsVWQvifIYf40dJPZkk9YgGTzWLpXDSfLSplbY2LL9C9U0ptvjcDjefLTvqSFc7t w1sEhF0n/qpA2r0GpvkLRDmcSwVyPvmjFBGqUp/pNy8ZuPGQmHwFi2/14+xeSUDG2bwnsYJQ G2EdJCB6luQ57GEnTA/yKZSTKI8dDQa8Sd3zfXb19mOgSF0bBdXbuKhEpuP9wirslFe6fQ1t 5j5R0xi72MZ8ikMu1RQZKCyDbMwazlHiMIIGOzCCBSOgAwIBAgIDCz+cMA0GCSqGSIb3DQEB CwUAMIGMMQswCQYDVQQGEwJJTDEWMBQGA1UEChMNU3RhcnRDb20gTHRkLjErMCkGA1UECxMi U2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUgU2lnbmluZzE4MDYGA1UEAxMvU3RhcnRDb20g Q2xhc3MgMSBQcmltYXJ5IEludGVybWVkaWF0ZSBDbGllbnQgQ0EwHhcNMTQwOTE5MDkyNjU5 WhcNMTUwOTIwMDAyMjU4WjBEMQswCQYDVQQGEwJDQTEZMBcGA1UEAxMQSmVhbi1NYXJjIFBp Z2VvbjEaMBgGCSqGSIb3DQEJARYLam1wQHNhZmUuY2EwggEiMA0GCSqGSIb3DQEBAQUAA4IB DwAwggEKAoIBAQCq9xU31qh4GocaLlpWBFhfbsocoZcrPC5/vYc53dzp2sc9dLGE8wJTJpGF AMVajOosoGx11kV76DmdF2gWTOjl2tNxgTlfjDtgqeuY6laDfPEoYquzcqvNAFigAhzV+oIR 1WD6RROEt7mWar8DFYvqovwGN1NWGHqnwLQ8eWa/xN/rC+rzxpFfBJKPPgaaLPSLkoAJg1Iv LrEbGgofvO+2gq46goCXvobTmCB4fG+lCqcxoAvFuGv5aJQUIyg0LrZSCsQYc7G9Z+eMNK12 pBUzMsUwgbjBu/owa0dnc452YaZHI0dq1X+27FP+vVxJdO2U6opebBk04BVvOaOtGZyPAgMB AAGjggLrMIIC5zAJBgNVHRMEAjAAMAsGA1UdDwQEAwIEsDAdBgNVHSUEFjAUBggrBgEFBQcD AgYIKwYBBQUHAwQwHQYDVR0OBBYEFHzO2KvU9lX+uTCC7EFVdrvVptoXMB8GA1UdIwQYMBaA FFNy7ZKc4NrLAVx8fpY1TvLUuFGCMBYGA1UdEQQPMA2BC2ptcEBzYWZlLmNhMIIBZgYDVR0g BIIBXTCCAVkwggFVBgsrBgEEAYG1NwECAzCCAUQwLgYIKwYBBQUHAgEWImh0dHA6Ly93d3cu c3RhcnRzc2wuY29tL3BvbGljeS5wZGYwggEQBggrBgEFBQcCAjCCAQIwJxYgU3RhcnRDb20g Q2VydGlmaWNhdGlvbiBBdXRob3JpdHkwAwIBARqB1lRoaXMgY2VydGlmaWNhdGUgd2FzIGlz c3VlZCBhY2NvcmRpbmcgdG8gdGhlIFN0YXJ0U1NMIFdlYi1vZi1UcnVzdCBDb21tdW5pdHkg VmFsaWRhdGlvbiByZXF1aXJlbWVudHMgb2YgdGhlIFN0YXJ0Q29tIENBIHBvbGljeSwgcmVs aWFuY2Ugb25seSBmb3IgdGhlIGludGVuZGVkIHB1cnBvc2UgaW4gY29tcGxpYW5jZSBvZiB0 aGUgcmVseWluZyBwYXJ0eSBvYmxpZ2F0aW9ucy4wNgYDVR0fBC8wLTAroCmgJ4YlaHR0cDov L2NybC5zdGFydHNzbC5jb20vY3J0dTEtY3JsLmNybDCBjgYIKwYBBQUHAQEEgYEwfzA5Bggr BgEFBQcwAYYtaHR0cDovL29jc3Auc3RhcnRzc2wuY29tL3N1Yi9jbGFzczEvY2xpZW50L2Nh MEIGCCsGAQUFBzAChjZodHRwOi8vYWlhLnN0YXJ0c3NsLmNvbS9jZXJ0cy9zdWIuY2xhc3Mx LmNsaWVudC5jYS5jcnQwIwYDVR0SBBwwGoYYaHR0cDovL3d3dy5zdGFydHNzbC5jb20vMA0G CSqGSIb3DQEBCwUAA4IBAQAvqGXpalMzkxyvuW6F4AJpyxCQfZElU4Xta8ChoYYOM+8mbznZ qmGhQsIgRREuRcmCCO3Ei9CZ9DvgXtOrZHAOTLoLadl/Z/A2C0QOrTPG7UiUQTQJQlubgy41 2T4b9mtIHxy+bLofsC4SnPRhSRCKAAtNPSBqPKoF9pQdAGdx2/7JGPuHLd6vH93IcZtsQcmk SjpLqGR7YSl7vSy4i/JypO5bfGTAdJPDPEHuqMYd8bM2frS9Dv6+yAb1S8C7e2032r4MUsLx 4aw5RZ5N8BqpUv9XNUr68P38B6Q/FBtZgDloUNB/Py77fLTbGq1xYhHTG8uKOlRNkWx/IZnM JFPTMYID3TCCA9kCAQEwgZQwgYwxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1TdGFydENvbSBM dGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWduaW5nMTgwNgYD VQQDEy9TdGFydENvbSBDbGFzcyAxIFByaW1hcnkgSW50ZXJtZWRpYXRlIENsaWVudCBDQQID Cz+cMAkGBSsOAwIaBQCgggIdMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTE1MDQyMzEyNTg1MFowIwYJKoZIhvcNAQkEMRYEFCcujbnj4UqVqhn0XeyUWM3I fgvKMGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBAjAKBggqhkiG 9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYIKoZIhvcN AwICASgwgaUGCSsGAQQBgjcQBDGBlzCBlDCBjDELMAkGA1UEBhMCSUwxFjAUBgNVBAoTDVN0 YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENlcnRpZmljYXRlIFNpZ25p bmcxODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNzIDEgUHJpbWFyeSBJbnRlcm1lZGlhdGUgQ2xp ZW50IENBAgMLP5wwgacGCyqGSIb3DQEJEAILMYGXoIGUMIGMMQswCQYDVQQGEwJJTDEWMBQG A1UEChMNU3RhcnRDb20gTHRkLjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNh dGUgU2lnbmluZzE4MDYGA1UEAxMvU3RhcnRDb20gQ2xhc3MgMSBQcmltYXJ5IEludGVybWVk aWF0ZSBDbGllbnQgQ0ECAws/nDANBgkqhkiG9w0BAQEFAASCAQCqgS0/x6ZbsbrKFHXgeE9+ BpJqhhG0cxU+p0UKg5kStR33amV1aPnd3WTGNofCkwDqBpkwIsc8dSnRIHWudiHr7s3RZEmk GhgM2BRRVAKFCJotyldCqoGLD3Ttk5p0ntk1PugAZBOS8G3zW/URynS44824599QU0ofN8/i XM1gAIpxlWD1m/dEuOQbByUrxLDAQGC0n1v8HpInpf/XZxVqcpzqUxudpTWxHEsgpNq320Rx 2hXfvwKf+Ld4LmWpJ5Uu2H/xK8ehJmiHyjA3nHSVNnKMnHaczukIsRy03b1JF7yyfHaAJzPE nnLgPcqZqHt5xK2PLCmP43vs2wVzpmi7AAAAAAAA --------------ms010900070701040004020805--