From: "Stefan Kanthak" <stefan.kanthak@nexgo.de>
To: <musl@lists.openwall.com>
Subject: [PATCH] fmax(), fmaxf(), fmaxl(), fmin(), fminf(), fminl() simplified
Date: Wed, 11 Dec 2019 10:55:29 +0100 [thread overview]
Message-ID: <557979287957451E9255CCBC4CD7CBE5@H270> (raw)
Still more optimisations/simplifications in the math subtree.
JFTR: I'm NOT subscribed to your mailing list, so CC: me in replies!
--- -/src/math/fmax.c
+++ +/src/math/fmax.c
@@ -3,11 +3,9 @@
double fmax(double x, double y)
{
- if (isnan(x))
+ if (x != x)
return y;
- if (isnan(y))
- return x;
/* handle signed zeros, see C99 Annex F.9.9.2 */
- if (signbit(x) != signbit(y))
+ if (x == y)
return signbit(x) ? y : x;
return x < y ? y : x;
}
--- -/src/math/fmaxf.c
+++ +/src/math/fmaxf.c
@@ -3,11 +3,9 @@
float fmaxf(float x, float y)
{
- if (isnan(x))
+ if (x != x)
return y;
- if (isnan(y))
- return x;
/* handle signed zeros, see C99 Annex F.9.9.2 */
- if (signbit(x) != signbit(y))
+ if (x == y)
return signbit(x) ? y : x;
return x < y ? y : x;
}
--- -/src/math/fmaxl.c
+++ +/src/math/fmaxl.c
@@ -10,11 +10,9 @@
long double fmaxl(long double x, long double y)
{
- if (isnan(x))
+ if (x != x)
return y;
- if (isnan(y))
- return x;
/* handle signed zeros, see C99 Annex F.9.9.2 */
- if (signbit(x) != signbit(y))
+ if (x == y)
return signbit(x) ? y : x;
return x < y ? y : x;
}
--- -/src/math/fmin.c
+++ +/src/math/fmin.c
@@ -3,11 +3,9 @@
double fmin(double x, double y)
{
- if (isnan(x))
+ if (x != x)
return y;
- if (isnan(y))
- return x;
/* handle signed zeros, see C99 Annex F.9.9.2 */
- if (signbit(x) != signbit(y))
+ if (x == y)
return signbit(x) ? x : y;
- return x < y ? x : y;
+ return x > y ? y : x;
}
--- -/src/math/fminf.c
+++ +/src/math/fminf.c
@@ -3,11 +3,9 @@
float fminf(float x, float y)
{
- if (isnan(x))
+ if (x != x)
return y;
- if (isnan(y))
- return x;
/* handle signed zeros, see C99 Annex F.9.9.2 */
- if (signbit(x) != signbit(y))
+ if (x == y)
return signbit(x) ? x : y;
- return x < y ? x : y;
+ return x > y ? y : x;
}
--- -/src/math/fminl.c
+++ +/src/math/fminl.c
@@ -10,11 +10,9 @@
long double fminl(long double x, long double y)
{
- if (isnan(x))
+ if (x != x)
return y;
- if (isnan(y))
- return x;
/* handle signed zeros, see C99 Annex F.9.9.2 */
- if (signbit(x) != signbit(y))
+ if (x == y)
return signbit(x) ? x : y;
- return x < y ? x : y;
+ return x > y ? y : x;
}
next reply other threads:[~2019-12-11 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 9:55 Stefan Kanthak [this message]
2019-12-11 10:49 ` Szabolcs Nagy
2019-12-11 12:33 ` Stefan Kanthak
2019-12-11 13:16 ` Szabolcs Nagy
2019-12-11 13:25 ` Rich Felker
2019-12-11 21:17 ` Stefan Kanthak
2019-12-11 21:30 ` Rich Felker
2019-12-11 22:25 ` Stefan Kanthak
2019-12-11 22:14 ` Damian McGuckin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557979287957451E9255CCBC4CD7CBE5@H270 \
--to=stefan.kanthak@nexgo.de \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).