From: Alexander Cherepanov <ch3root@openwall.com>
To: musl@lists.openwall.com
Subject: Re: string word-at-a-time and atomic.h FAQ on twitter
Date: Sat, 9 Jan 2016 00:59:55 +0300 [thread overview]
Message-ID: <5690315B.5010206@openwall.com> (raw)
In-Reply-To: <20160105175040.GA238@brightrain.aerifal.cx>
On 2016-01-05 20:50, Rich Felker wrote:
> So we could just consider trying to drop the OOB
> accesses. Do we have a list of affected functions? That might be nice
> to include.
I think it would be nice to have a full list of intentional UB. For
example, this:
http://git.musl-libc.org/cgit/musl/tree/src/stdio/vsnprintf.c#n33
if (n > (char *)0+SIZE_MAX-s-1) n = (char *)0+SIZE_MAX-s-1;
If I understand the code correctly, fixing it will require changes to
the FILE structure. Are there such plans?
>> this takes care of oob access, but the bytes outside the passed
>> object might change concurrently i.e. strlen might introduce a
>> data race: again this is a problem on the abstract c language
>> level that may be solved e.g. by making all accesses to those
>> bytes relaxed atomic, but user code is not under libc control.
>> in practice the code works if HASZERO reads the word once so it
>> does arithmetics with a consistent value (because the memory
>> model of the underlying machine does not treat such race
>> undefined and it does not propagate unspecified value bits nor
>> has trap representations).
>
> Indeed, this seems like less of a practical concern.
HASZERO reads the word twice so this should be a problem for unoptimized
code on big-endian platforms.
--
Alexander Cherepanov
next prev parent reply other threads:[~2016-01-08 21:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 16:46 Szabolcs Nagy
2016-01-05 17:50 ` Rich Felker
2016-01-05 23:39 ` Matthew Fernandez
2016-01-06 2:56 ` Szabolcs Nagy
2016-01-08 21:59 ` Alexander Cherepanov [this message]
2016-01-08 22:05 ` Rich Felker
2016-01-08 22:39 ` Alexander Cherepanov
2016-01-08 22:59 ` Rich Felker
2016-01-09 1:40 ` Szabolcs Nagy
2016-01-12 12:41 ` Alexander Cherepanov
2016-01-12 21:02 ` Alexander Cherepanov
2016-01-12 21:09 ` Alexander Cherepanov
2016-01-12 23:07 ` Szabolcs Nagy
2016-01-13 17:30 ` Szabolcs Nagy
2016-01-14 12:49 ` Szabolcs Nagy
2016-01-14 22:51 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5690315B.5010206@openwall.com \
--to=ch3root@openwall.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).