From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9127 Path: news.gmane.org!not-for-mail From: Ron Yorston Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] fix if_nametoindex return value when socket open fails Date: Fri, 15 Jan 2016 09:39:44 +0000 Message-ID: <5698be60.uat8s3q4Wfvl5TQE%rmy@frippery.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1452850817 20628 80.91.229.3 (15 Jan 2016 09:40:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Jan 2016 09:40:17 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9140-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jan 15 10:40:17 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1aK0rg-0001Et-8O for gllmg-musl@m.gmane.org; Fri, 15 Jan 2016 10:40:16 +0100 Original-Received: (qmail 31746 invoked by uid 550); 15 Jan 2016 09:40:14 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 30527 invoked from network); 15 Jan 2016 09:40:08 -0000 User-Agent: Heirloom mailx 12.4 7/29/08 Xref: news.gmane.org gmane.linux.lib.musl.general:9127 Archived-At: The return value of if_nametoindex is unsigned; it should return 0 on error. --- src/network/if_nametoindex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/if_nametoindex.c b/src/network/if_nametoindex.c index cb6ec05..331413c 100644 --- a/src/network/if_nametoindex.c +++ b/src/network/if_nametoindex.c @@ -10,7 +10,7 @@ unsigned if_nametoindex(const char *name) struct ifreq ifr; int fd, r; - if ((fd = socket(AF_UNIX, SOCK_DGRAM|SOCK_CLOEXEC, 0)) < 0) return -1; + if ((fd = socket(AF_UNIX, SOCK_DGRAM|SOCK_CLOEXEC, 0)) < 0) return 0; strncpy(ifr.ifr_name, name, sizeof ifr.ifr_name); r = ioctl(fd, SIOCGIFINDEX, &ifr); __syscall(SYS_close, fd); -- 2.5.0