From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9759
Path: news.gmane.org!not-for-mail
From: Patrick Oppenlander <pattyo.lists@gmail.com>
Newsgroups: gmane.linux.lib.musl.general
Subject: Re: [PATCH 2/2] add powerpc64 port
Date: Tue, 29 Mar 2016 09:00:19 +1100
Message-ID: <56F9A973.2040809@gmail.com>
References: <1459113619-24090-1-git-send-email-koorogi@koorogi.info>
 <1459113619-24090-3-git-send-email-koorogi@koorogi.info>
 <20160327233709.GE21636@brightrain.aerifal.cx>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Trace: ger.gmane.org 1459202447 27124 80.91.229.3 (28 Mar 2016 22:00:47 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Mon, 28 Mar 2016 22:00:47 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-9772-gllmg-musl=m.gmane.org@lists.openwall.com Tue Mar 29 00:00:47 2016
Return-path: <musl-return-9772-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@m.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-9772-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1akfDK-0006Lu-LD
	for gllmg-musl@m.gmane.org; Tue, 29 Mar 2016 00:00:46 +0200
Original-Received: (qmail 28196 invoked by uid 550); 28 Mar 2016 22:00:42 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Original-Received: (qmail 28175 invoked from network); 28 Mar 2016 22:00:41 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
In-Reply-To: <20160327233709.GE21636@brightrain.aerifal.cx>
Xref: news.gmane.org gmane.linux.lib.musl.general:9759
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/9759>

On 28/03/16 10:37, Rich Felker wrote:
> This is kind of the reason why I was hesitant to add .S support for so
> long. :-)
>
> I don't want to reject it outright, but the idea of adding .S support
> was just to allow conditional compilation, not to do condensed
> assembly sources that require macro expansion. I can see where the
> code might be unwieldy without this though. Anyone else have opinions?

IMHO .S support is worthwhile just to be able to use constant 
definitions in assembly.

For example,

__unmapself:
     mov r7,#SYS_munmap
     svc 0
     mov r7,#SYS_exit
     svc 0

Is a clearer than:

__unmapself:
     mov r7,#91
     svc 0
     mov r7,#1
     svc 0

Especially when approaching the source for the first time.

         Patrick