mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Matthew Fernandez <matthew.fernandez@nicta.com.au>
To: <musl@lists.openwall.com>
Subject: Undetected failures in getdomainname
Date: Wed, 22 Jun 2016 18:15:25 +1000	[thread overview]
Message-ID: <576A491D.7030509@nicta.com.au> (raw)

Hi all,

In the tip at time of writing (6cec7bc57f599f43f4041cec2093e3c9231dbaab) there are a couple of
syscalls that are implemented by calling uname, notably gethostname and getdomainname. In
gethostname, the return value of uname is checked and the code returns early if uname fails.
However, in getdomainname the return value of uname is ignored. I think it should be following the
same pattern as gethostname. Is this correct?

Also, gethostname rolls its own strcpy, while getdomainname just calls strcpy. However, maybe there
is a good reason for this.

If replying, please CC me directly as I'm not on the list.

Thanks,
Matthew

________________________________

The information in this e-mail may be confidential and subject to legal professional privilege and/or copyright. National ICT Australia Limited accepts no liability for any damage caused by this email or its attachments.


             reply	other threads:[~2016-06-22  8:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22  8:15 Matthew Fernandez [this message]
2016-06-22 16:31 ` Rich Felker
2016-06-23  0:17   ` Matthew Fernandez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576A491D.7030509@nicta.com.au \
    --to=matthew.fernandez@nicta.com.au \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).