From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10186 Path: news.gmane.org!not-for-mail From: Matthew Fernandez Newsgroups: gmane.linux.lib.musl.general Subject: Undetected failures in getdomainname Date: Wed, 22 Jun 2016 18:15:25 +1000 Message-ID: <576A491D.7030509@nicta.com.au> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1466583349 1787 80.91.229.3 (22 Jun 2016 08:15:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Jun 2016 08:15:49 +0000 (UTC) To: Original-X-From: musl-return-10199-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jun 22 10:15:49 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1bFdK7-0002YU-FC for gllmg-musl@m.gmane.org; Wed, 22 Jun 2016 10:15:47 +0200 Original-Received: (qmail 25923 invoked by uid 550); 22 Jun 2016 08:15:45 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 25861 invoked from network); 22 Jun 2016 08:15:40 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 Xref: news.gmane.org gmane.linux.lib.musl.general:10186 Archived-At: Hi all, In the tip at time of writing (6cec7bc57f599f43f4041cec2093e3c9231dbaab) th= ere are a couple of syscalls that are implemented by calling uname, notably gethostname and get= domainname. In gethostname, the return value of uname is checked and the code returns earl= y if uname fails. However, in getdomainname the return value of uname is ignored. I think it = should be following the same pattern as gethostname. Is this correct? Also, gethostname rolls its own strcpy, while getdomainname just calls strc= py. However, maybe there is a good reason for this. If replying, please CC me directly as I'm not on the list. Thanks, Matthew ________________________________ The information in this e-mail may be confidential and subject to legal pro= fessional privilege and/or copyright. National ICT Australia Limited accept= s no liability for any damage caused by this email or its attachments.