From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13165 Path: news.gmane.org!.POSTED!not-for-mail From: Fangrui Song Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] simplify __procfdname by folding the 0 case Date: Sun, 2 Sep 2018 00:51:37 -0700 Message-ID: <5b8b9a8b.1c69fb81.ed159.bb37@mx.google.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1535875615 25270 195.159.176.226 (2 Sep 2018 08:06:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Sep 2018 08:06:55 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-13181-gllmg-musl=m.gmane.org@lists.openwall.com Sun Sep 02 10:06:51 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fwNPH-0006Tr-CZ for gllmg-musl@m.gmane.org; Sun, 02 Sep 2018 10:06:51 +0200 Original-Received: (qmail 30623 invoked by uid 550); 2 Sep 2018 08:08:57 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 30584 invoked from network); 2 Sep 2018 08:08:56 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:sender:from:date:subject:to; bh=bMi7bzPQzY3TVwQCRn06VkEcpw4r0NaNRJQcg6PFssE=; b=W6cTw4Eor/c0zFFypEOUktdm4dYOK/F74TpqLuhaPGnam4amgXoCiKURfai+QKSoum nj7G0Y5WphObVvMxvxWDWicLJWTbzQc8bekMniDA+tDkcGr57nvmWqeBOnPCn0Z2mcEO dyjZZzWcFeO51dOpU2CY0kyySfUpYqeCSJsFB4LQ/dq62bIxd9fcqj+WupysmIuZyAPr YuimBbxx6ddWXcxj1XYKI0C/Epm739/wv9cH8Zr8kfIdWVN8V1yJ0psXi+DuMFrN8t1C w9tusVEJEh2ADW2uidrxneQti78kRDVO/Ivd6E1dNBfwPmg3IsRr/I3YwwdzL5yTXJBv ij6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:sender:from:date:subject:to; bh=bMi7bzPQzY3TVwQCRn06VkEcpw4r0NaNRJQcg6PFssE=; b=F+mDqC9n7vs/WAHsonKIbjaqAVxW+YEbiQQNYRt40XfgwaUVlEWg7ftXnDMjs8fX9j dpUtpJg1zWSAKeEDZSHNzgrmqccOa2liZOaLmIRy9W7Zfe/LYi1xiKES3WaJtSpPe7c1 XjFLOLhRyv+N6VpUd6JVAF0Hf1o9RR5N5ohaIfomOxAbuG5I9gKtoAER2SirXGORieh7 NC2JFtvktmxqPIT5Bnw+KTXljYUmwQw+j64puf17YKdXNnkQxq6Iu8Qd5T0UAyrND8v8 AMgfdrKiQDHNmIHPYTDIkPl7yRrZwns2fb8YWy43OFDfQ6vneh32qKlYgxiuiwbncoeA fhyQ== X-Gm-Message-State: APzg51BeffXHmhojNcDI8GO5MD2fXPRmHvC7yf/JHdXg9Auowp9I73ip 3jjOBqHBm1FNbJaBE4HR9w5B4Zgb X-Google-Smtp-Source: ANB0Vda96YtgwkbsMR3C3RfVnsIG0OThCzyRqqo+rmNTfT1zCQEZZ7kJECl7ezomqpSPM1keMi8/9Q== X-Received: by 2002:a17:902:b7c5:: with SMTP id v5-v6mr23397560plz.49.1535875723795; Sun, 02 Sep 2018 01:08:43 -0700 (PDT) Original-Sender: =?UTF-8?B?RsSBbmctcnXDrCBTw7JuZw==?= Xref: news.gmane.org gmane.linux.lib.musl.general:13165 Archived-At: --- src/internal/procfdname.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/internal/procfdname.c b/src/internal/procfdname.c index 697e0bdc..5046abaa 100644 --- a/src/internal/procfdname.c +++ b/src/internal/procfdname.c @@ -2,12 +2,7 @@ void __procfdname(char *buf, unsigned fd) { unsigned i, j; for (i=0; (buf[i] = "/proc/self/fd/"[i]); i++); - if (!fd) { - buf[i] = '0'; - buf[i+1] = 0; - return; - } - for (j=fd; j; j/=10, i++); - buf[i] = 0; - for (; fd; fd/=10) buf[--i] = '0' + fd%10; + for (j=fd; i++, j /= 10; ); + buf[i] = '\0'; + while (buf[--i] = '0' + fd%10, fd /= 10); } -- 2.18.0