From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/46 Path: news.gmane.org!not-for-mail From: Igmar Palsenberg Newsgroups: gmane.linux.lib.musl.general Subject: Re: Cleanup patches Date: Tue, 7 Jun 2011 11:08:49 +0200 Message-ID: <61229B7E-0DAF-4644-9890-5AC54024CE06@palsenberg.com> References: <60BABB60-7D9B-4D66-8645-4CDFD07E1338@palsenberg.com> <20110606171317.GN6142@port70.net> <20110606173210.GD191@brightrain.aerifal.cx> <495DC2BF-B857-4BD5-95B1-753C0DB0DE6A@palsenberg.com> <20110607090609.GB5512@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1307437760 11754 80.91.229.12 (7 Jun 2011 09:09:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Jun 2011 09:09:20 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-129-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jun 07 11:09:14 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QTsHh-0004cQ-58 for gllmg-musl@lo.gmane.org; Tue, 07 Jun 2011 11:09:13 +0200 Original-Received: (qmail 18383 invoked by uid 550); 7 Jun 2011 09:09:12 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 18375 invoked from network); 7 Jun 2011 09:09:12 -0000 In-Reply-To: <20110607090609.GB5512@port70.net> X-Mailer: Apple Mail (2.1084) Xref: news.gmane.org gmane.linux.lib.musl.general:46 Archived-At: > a superfluous type cast is not OK even if it's a NOOP > it's ugly, dangerous and surprising >=20 > in this case the cast hides an important warning: > wchar_t of musl and the compiler is different > the solution is to define wchar_t properly >=20 > it seems pcc and gcc defines __WCHAR_TYPE__ > if clang has it defined as well then i guess musl can use it > and fall back to int when it's not defined Indeed.. I was bluntly assuming all compilers use the same type. I'll = see if I can fix it the proper way. Igmar=