bug in getopt_long()

["Anthony G. Basile" <basile@freeharbor.net>]

[-- Attachment #1: Type: text/plain, Size: 795 bytes --]

Hi,

We hit a bug in Gentoo with getopt_long().  It appears the alpine people
hit it too http://bugs.alpinelinux.org/issues/4802.  The problem was
encountered in open-iscsi but I got some reduced code which I've
attached.  If you build and run that code as `./test --portal
10.144.0.14 --discover` then you get

p
D
unrecognized character 'D'

On a glibc system, you don't get the "unrecognized character 'D'" which
is what we'd expect.  Rich suggested a patch to musl which looked like
it might work, but it didn't.  I didn't investigate further.  I'm just
reporting it first to see if others know what's up.


-- 
Anthony G. Basile, Ph.D.
Gentoo Linux Developer [Hardened]
E-Mail    : basile@freeharbor.net
GnuPG FP  : 1FED FAD9 D82C 52A5 3BAB  DC79 9384 FA6E F52D 4BBA
GnuPG ID  : F52D4BBA



[-- Attachment #2: test.c --]
[-- Type: text/plain, Size: 626 bytes --]

#include <getopt.h>
#include <stdio.h>

static struct option const long_options[] =
{
    {"portal", required_argument, NULL, 'p'},
    {"discover", no_argument, NULL, 'D'},
    {NULL, 0, NULL, 0},
};

static char *short_options = "Dp:";

int main(int argc, char **argv)
{
    int ch, longindex;
    optopt = 0;
    while ((ch = getopt_long(argc, argv, short_options, long_options, &longindex)) >= 0) {
        switch (ch) {
        case 'D':
            printf("D\n");
            break;
        case 'p':
            printf("p\n");
        }
    }

    if (optopt)
        printf("unrecognized character '%c'\n", optopt);
}