From: Stefan Agner <stefan@agner.ch>
To: musl@lists.openwall.com
Cc: "Érico Rolim" <ericonr@disroot.org>
Subject: Re: [musl] [PATCH] add pthread_getname_np function
Date: Thu, 20 May 2021 15:04:36 +0200 [thread overview]
Message-ID: <68dedc6479ed7a6bbce271a6de3fba6c@agner.ch> (raw)
In-Reply-To: <20210420191519.23822-1-ericonr@disroot.org>
Hi,
On 2021-04-20 21:15, Érico Nogueira wrote:
> From: Érico Rolim <ericonr@disroot.org>
>
> based on the pthread_setname_np implementation
> ---
>
> I might have forgotten to send this final version here
>
> include/pthread.h | 1 +
> src/thread/pthread_getname_np.c | 25 +++++++++++++++++++++++++
> 2 files changed, 26 insertions(+)
> create mode 100644 src/thread/pthread_getname_np.c
>
> diff --git a/include/pthread.h b/include/pthread.h
> index 0492f26a..89fd9ff7 100644
> --- a/include/pthread.h
> +++ b/include/pthread.h
> @@ -221,6 +221,7 @@ int pthread_getaffinity_np(pthread_t, size_t,
> struct cpu_set_t *);
> int pthread_setaffinity_np(pthread_t, size_t, const struct cpu_set_t *);
> int pthread_getattr_np(pthread_t, pthread_attr_t *);
> int pthread_setname_np(pthread_t, const char *);
> +int pthread_getname_np(pthread_t, char *, size_t);
> int pthread_getattr_default_np(pthread_attr_t *);
> int pthread_setattr_default_np(const pthread_attr_t *);
> int pthread_tryjoin_np(pthread_t, void **);
> diff --git a/src/thread/pthread_getname_np.c b/src/thread/pthread_getname_np.c
> new file mode 100644
> index 00000000..48d1a294
> --- /dev/null
> +++ b/src/thread/pthread_getname_np.c
> @@ -0,0 +1,25 @@
> +#define _GNU_SOURCE
> +#include <fcntl.h>
> +#include <unistd.h>
> +#include <sys/prctl.h>
> +
> +#include "pthread_impl.h"
> +
> +int pthread_getname_np(pthread_t thread, char *name, size_t len)
> +{
> + int fd, cs, status = 0;
> + char f[sizeof "/proc/self/task//comm" + 3*sizeof(int)];
> +
> + if (len < 16) return ERANGE;
> +
> + if (thread == pthread_self())
> + return prctl(PR_GET_NAME, (unsigned long)name, 0UL, 0UL, 0UL) ? errno : 0;
> +
> + snprintf(f, sizeof f, "/proc/self/task/%d/comm", thread->tid);
> + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &cs);
> + if ((fd = open(f, O_RDONLY|O_CLOEXEC)) < 0 || (len = read(fd, name,
> len)) < 0) status = errno;
> + else name[len-1] = 0; /* remove trailing new line only if successful */
It seems that Linux indeed always adds a newline, so removing it
unconditionally seems fine.
> + if (fd >= 0) close(fd);
> + pthread_setcancelstate(cs, 0);
> + return status;
> +}
Looks good to me:
Reviewed-by: Stefan Agner <stefan@agner.ch>
FWIW, We carry basically the same patch for musl to build TensorFlow and
I was about to post it.
--
Stefan
next prev parent reply other threads:[~2021-05-20 13:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 19:15 Érico Nogueira
2021-04-20 19:15 ` [musl] [PATCH v2] define __STDC_UTF_{16,32}__ macros Érico Nogueira
2021-04-20 19:15 ` [musl] [PATCH] extend gethostid beyond a stub Érico Nogueira
2021-04-20 19:15 ` [musl] [PATCH] remove unnecessary cast for map_library return Érico Nogueira
2021-04-20 19:15 ` [musl] [PATCH] shorten __aeabi_memset by one instruction Érico Nogueira
2021-04-21 8:24 ` Szabolcs Nagy
2021-04-21 12:32 ` Jesse DeGuire
2021-04-21 17:38 ` Rich Felker
2021-04-21 19:02 ` Érico Nogueira
2021-05-20 13:04 ` Stefan Agner [this message]
2021-07-09 8:06 ` [musl] [PATCH] add pthread_getname_np function Michael Forney
-- strict thread matches above, loose matches on Subject: below --
2021-03-25 20:19 Érico Nogueira
2020-12-19 18:37 Érico Nogueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68dedc6479ed7a6bbce271a6de3fba6c@agner.ch \
--to=stefan@agner.ch \
--cc=ericonr@disroot.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).