From: Hongliang Wang <wanghongliang@loongson.cn>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] LoongArch: delete bits/ptrace.h
Date: Fri, 1 Mar 2024 10:00:40 +0800 [thread overview]
Message-ID: <6fb99f49-e8b0-9a7c-9d16-2546bda888bf@loongson.cn> (raw)
In-Reply-To: <20240229222918.GX4163@brightrain.aerifal.cx>
在 2024/3/1 上午6:29, Rich Felker 写道:
> On Wed, Feb 28, 2024 at 03:27:07PM +0800, Hongliang Wang wrote:
>> Hi,
>>
>> Delete loongarch64/bits/ptrace.h, the PTRACE related macro definitions
>> are not used in loongarch.
>
> I'm applying this based on being unable to find macros like these in
> the glibc loongarch64 target, but for future reference, please include
> with patches like this an explanation of why they're being removed --
> whether they were originally added by mistake, or added intentionally
> but then it was decided not to support them, or whatever.
>
> Rich
>
Sorry, it was my mistake that I didn't explain the reason clearly.
Initialy, these macros in ptrace.h were ported with reference to mips,
they are not used in loongarch, so they were originally added by mistake.
Thank you for pointing out the issue.
Regards,
Hongliang Wang
prev parent reply other threads:[~2024-03-01 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 7:27 Hongliang Wang
2024-02-29 22:29 ` Rich Felker
2024-03-01 2:00 ` Hongliang Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fb99f49-e8b0-9a7c-9d16-2546bda888bf@loongson.cn \
--to=wanghongliang@loongson.cn \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).