From: Mark Wielaard <mark@klomp.org>
To: Max Rees <maxcrees@me.com>, musl@lists.openwall.com
Cc: elfutils-devel@sourceware.org, "Érico Rolim" <erico.erc@gmail.com>
Subject: Re: [musl] Re: [QUESTION] Which fnmatch() functionality does elfutils depend on?
Date: Mon, 26 Oct 2020 23:32:23 +0100 [thread overview]
Message-ID: <73a9e67dd5887f31663ef3ac4e9c683a133b3a0d.camel@klomp.org> (raw)
In-Reply-To: <20201026175430.GA6473@sachiel>
Hi Max,
On Mon, 2020-10-26 at 13:54 -0400, Max Rees via Elfutils-devel wrote:
> On Mon Oct 26 01:28 PM, Érico Nogueira wrote:
> > On Mon Oct 26, 2020 at 3:10 PM -03, Mark Wielaard wrote:
> > > On Mon, 2020-10-26 at 12:03 -0300, Érico Nogueira via Elfutils-
> > > devel
> > > wrote:
> > > > Do elfutils program actually depend on the extra functionality
> > > > enabled by
> > > > FNM_EXTMATCH? Is changing the flag to have no effect a "bug"?
> > >
> > > Yes. The extended wildcard pattern is relied upon by both
> > > eu-strip with
> > >
> > > --keep-section=SECTION Keep the named section. SECTION is an
> > > extended wildcard pattern. May be given
> > > more than once.
> > >
> > > and eu-elfcompress with
> > >
> > > -n, --name=SECTION SECTION name to (de)compress, SECTION is an
> > > extended wildcard pattern (defaults to
> > > '.?(z)debug*')
> > >
> > > In the eu-strip case it might be reasoned that instead of a
> > > wildcard pattern the user might most of the time simply provide
> > > a section name as is (especially since the option may be given
> > > multiple times). But in the case of eu-elfcompress the
> > > program relies on the default SECTION name being an extended
> > > wildcard pattern. So not supporting FNM_EXTMATCH breaks the
> > > default functionality of eu-elfcompress.
> >
> > Understood, thank you. I'm replying to the musl mailing list as well,
> > then, to hopefully gather more opinions, since I don't know what the
> > best way of solving this would be.
>
> When I was working on porting elfutils to Adélie (kind of on the
> backburner right now) I noticed this problem as well. Rather than try to
> add FNM_EXTMATCH support to musl, I worked around it in elfutils in this
> manner.
>
> 1. I changed the default like so:
>
> - add_pattern (".?(z)debug*");
> + add_pattern (".debug*");
> + add_pattern (".zdebug*");
>
> 2. I updated the corresponding help text to mention this new default.
>
> The user could do something similar themselves with multiple "-n"
> options.
That is a workaround to get a working build if your libc currently
doesn't provide a working fnmatch with FNM_EXTMATCH. But it would still
break the interface of the tools that currently accept an extended
wildcard pattern. So I think the best way forward is adding
FNM_EXTMATCH support to those libcs that don't support it yet (and
maybe get it standardized).
Cheers,
Mark
next prev parent reply other threads:[~2020-10-26 23:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <723b967389be88475206c5afc280c3be02ab677c.camel@klomp.org>
2020-10-26 17:28 ` Érico Nogueira
2020-10-26 17:54 ` Max Rees
2020-10-26 22:32 ` Mark Wielaard [this message]
2020-10-26 23:25 ` Rich Felker
2020-10-27 9:19 ` Florian Weimer
2020-10-27 15:04 ` Mark Wielaard
2020-10-27 17:08 ` Rich Felker
2020-10-27 22:19 ` Mark Wielaard
2020-10-27 22:25 ` Rich Felker
2020-10-28 10:05 ` Mark Wielaard
2020-10-28 14:03 ` Rich Felker
2020-10-26 19:55 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73a9e67dd5887f31663ef3ac4e9c683a133b3a0d.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=erico.erc@gmail.com \
--cc=maxcrees@me.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).