From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14302 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Samuel Holland Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 0/2] Resolve compiler warnings in master Date: Sat, 29 Jun 2019 18:05:31 -0500 Message-ID: <770e0f26-83d0-de0d-a48d-818c3aaccbbe@sholland.org> References: <20190629212244.42963-1-samuel@sholland.org> <20190629214622.GN1506@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="199377"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 To: musl@lists.openwall.com, Rich Felker Original-X-From: musl-return-14318-gllmg-musl=m.gmane.org@lists.openwall.com Sun Jun 30 01:05:50 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hhMPk-000pkk-Fk for gllmg-musl@m.gmane.org; Sun, 30 Jun 2019 01:05:49 +0200 Original-Received: (qmail 32661 invoked by uid 550); 29 Jun 2019 23:05:46 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 32619 invoked from network); 29 Jun 2019 23:05:45 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm3; bh=M 3P6TbAVEG3e1SMDXcde9vz07O+IjdCHLO1+ulvhDtI=; b=JnSOwj/pfTzhf9rO4 FHVecr4TVHSWgA/8NhNBdojxgvpQR+XqCjzEOqmrunBzYSVdXZ0hNoVX8Goyjxof px481AtkQHDTMloYQGcsivrDA6hGCii07vDD4cclGx0R/AS3rA6VNvhBVeINminn mZCao4ConZf3XBpAYrwRovmLF3TFW/wkJoVjLj51pDSAYxSFL7bmrPF+9A7vRfM3 HcrgrP3W1MlddaojNsy5w8ORYmdVQ9FnvXU/7l9LYNDQgq+sMBtgjsnajBsZmcvg ukEdcUkLIgW9Nor/B9ctK2wyeBJo12Q4Y26k2CEJw0qlXYqD4MUYfLKEzfryzo0G 5aZfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=M3P6TbAVEG3e1SMDXcde9vz07O+IjdCHLO1+ulvhD tI=; b=jY2WKBpd+lWjH3cpdIV0B9yZDLO7eTVCwCyloyn+Iu7qpT/uaS8SWt+II yGOFQtRbDFhHah64R5BlUZOPfG51Q3AjAEUtWnjhJOS+sQWk28OZtH+2UJYsdWbE T6RVEW9IjpJWeZTKyAc45o1EPW7+1YVLtP7uYCRLws+bxDLr6FcRar4UBrut+jR8 rYGvxlur2QSBvyY4Ye3tJSCkLJy59CnRH6bbzc0BX+bUh3Rvg6JdxceJ6DymiSRD Crd6iFwSDAgwM41HArKUCiaV3cepeMFfAuW9AYYqOdI7zYQhjUDVedMqrwiVO7zV /dgXRbPizvXD1XxkVh8Z6b12NoTGA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvdefgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepuffvfhfhkffffgggjggtgfesthejre dttdefjeenucfhrhhomhepufgrmhhuvghlucfjohhllhgrnhguuceoshgrmhhuvghlsehs hhholhhlrghnugdrohhrgheqnecukfhppeejtddrudefhedrudegkedrudehudenucfrrg hrrghmpehmrghilhhfrhhomhepshgrmhhuvghlsehshhholhhlrghnugdrohhrghenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: In-Reply-To: <20190629214622.GN1506@brightrain.aerifal.cx> Content-Language: en-US Xref: news.gmane.org gmane.linux.lib.musl.general:14302 Archived-At: On 6/29/19 4:46 PM, Rich Felker wrote: > On Sat, Jun 29, 2019 at 04:22:42PM -0500, Samuel Holland wrote: >> These two patches resolve some compiler warnings about mismatched >> attributes and restrict violations. There's another warning, related >> to duplicate definitions of TIOCSER_TEMT on some arches; I'm not sure >> which header needs to be changed. It results in: >> >> ../include/sys/ioctl.h:47: warning: "TIOCSER_TEMT" redefined >> >> The definitions are: >> >> arch/mips/bits/termios.h:#define TIOCSER_TEMT 0x01 >> arch/mips64/bits/termios.h:#define TIOCSER_TEMT 0x01 >> arch/mipsn32/bits/termios.h:#define TIOCSER_TEMT 0x01 >> arch/powerpc/bits/termios.h:#define TIOCSER_TEMT 0x01 >> arch/powerpc64/bits/termios.h:#define TIOCSER_TEMT 0x01 >> include/sys/ioctl.h:#define TIOCSER_TEMT 1 > > I don't see how this is happening with a consistent tree. Commit > 3517d74a5e04a377192d1f4882ad6c8dc22ce69a removed it from the bits > headers. That commit removed it from bits/ioctl.h. The definition is still in bits/termios.h, where it was changed in 9eda4dc69c33852c97c6f69176bf45ffc80b522f to match the old value in bits/ioctl.h. So maybe sys/ioctl.h needs to be changed from 1 to 0x01? Cheers, Samuel