mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Dominic Chen <d.c.ddcc@gmail.com>
To: musl@lists.openwall.com
Subject: [musl] fdopen() doesn't check for valid fd
Date: Fri, 26 Feb 2021 12:36:19 -0500	[thread overview]
Message-ID: <77f18b20-f3fc-7b07-42e8-8fa013e52ec9@gmail.com> (raw)

I've been verifying the behavior of an application between glibc and 
musl, and have noticed that the musl implementation of fdopen() assumes 
that the input fd is valid, whereas glibc does not. Per 
https://pubs.opengroup.org/onlinepubs/9699919799/, it seems that 
fdopen() is allowed to fail with EBADF, so inside __fdopen(), the 
syscalls to SYS_fcntl and SYS_ioctl should probably check for an error, 
deallocate the FILE *, and return nullptr.

Thanks,

Dominic




             reply	other threads:[~2021-02-26 17:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 17:36 Dominic Chen [this message]
2021-02-26 18:00 ` Rich Felker
2021-02-27 17:13   ` Khem Raj
2021-02-27 17:35     ` Rich Felker
2021-02-27 17:42       ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77f18b20-f3fc-7b07-42e8-8fa013e52ec9@gmail.com \
    --to=d.c.ddcc@gmail.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).