From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11043 Path: news.gmane.org!.POSTED!not-for-mail From: "Tuan M. Hoang" Newsgroups: gmane.linux.lib.musl.general Subject: Re: musl s390x bug Date: Wed, 15 Feb 2017 16:14:25 -0500 Message-ID: <79f3fcbc-3a44-8584-c766-9f83f76632ba@flatglobe.org> References: <43FE917A-48CB-4D0F-AD74-9B671B40F2CE@shiz.me> <20170206034553.GA19575@dora.lan> <20170215195700.GK1520@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1487193286 15617 195.159.176.226 (15 Feb 2017 21:14:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Feb 2017 21:14:46 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 To: musl@lists.openwall.com Original-X-From: musl-return-11058-gllmg-musl=m.gmane.org@lists.openwall.com Wed Feb 15 22:14:40 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ce6uM-0003Qr-BP for gllmg-musl@m.gmane.org; Wed, 15 Feb 2017 22:14:38 +0100 Original-Received: (qmail 5822 invoked by uid 550); 15 Feb 2017 21:14:42 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 5803 invoked from network); 15 Feb 2017 21:14:41 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flatglobe-org.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=nM/DOU4QoAv/q1tvdx84FGIvVueqXBJLXIkvbopPqWs=; b=zJuBELU6sfTITAi3aBwU0N/LWGt5RR3PEw5+Niivl35ZMdIiO9S5OJ87utIckswSjd 1HcM9VqR0J5lVFwgt+vDxp8BOfXoA7QzGTn7SOttbPumX4Bez4YC1d9VOGEgRbjY+jZF E+3f8Yy6ZdZTawaVPgIx+vF0yhCbgbjjrT1CUl9Uo1CpzrAdw3jaMvgDsgT6La/lnomw 5YoF81oaxcpt/kDDsa3AUXsPm47wsoqKakN5C5xO3yXbHL2eZKIOFAKIep0m7ee/CPgJ FHCwmKO2oSnnm2RlBmLpgWN0lhXW+0kGriOJrMykNhAYSJ/sVrIbF9X7cYM+QSY47tGl s7hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=nM/DOU4QoAv/q1tvdx84FGIvVueqXBJLXIkvbopPqWs=; b=e1104p57QVHmsBpiWpPkj5fawO3YVZfwpiFTSjr1OqCsaaZzA0VzijD9Y7RZ84Y/3q SLdLUlDONc6a+LtMfFeIqPAzyq7ZyDs8yvlzbzO+F3mm0gPOKVRHQ7wKd5mRV4zVsUYJ 9lmOPGddifjoTzCc93yt/uGqGp9aSmKhPWAhI0Q60gs/XfTw6As8GKI2wj328dAZAzxV yUZOp63r8nHz45B4gHKiQclqzKY4+jl7y1SiwlShG8tKD84fr48uAPa8U7mg+uGAgTjD g8fYHjcYVHkZUefmUIT0TIPTtuduY+GOQcY+DAnx7GVke8Emq6E4VzDjcBk3CI9DKBIO XzFA== X-Gm-Message-State: AMke39lMiRnkMM4WGyKDa1/Fi7C3dtKXYdcz2hwLhNIrngnIwxlFs5fs5kWVdTk8zreN5Q== X-Received: by 10.55.143.3 with SMTP id r3mr37289670qkd.152.1487193269668; Wed, 15 Feb 2017 13:14:29 -0800 (PST) In-Reply-To: <20170215195700.GK1520@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:11043 Archived-At: I applied both the patches from Bobby and fabled. Been testing for a while, no problem till now. And I was about to confirm it in a couple of days. Thanks, On 02/15/2017 02:57 PM, Rich Felker wrote: > On Sun, Feb 05, 2017 at 09:45:53PM -0600, Bobby Bingham wrote: >> On Sun, Feb 05, 2017 at 01:08:36AM +0100, Shiz wrote: >>> >>>> Then I applied Shiz's patch to src/ldso/s390x/dlsym.s : >>>> http://txt.shiz.me/M2Y5NGI3Ym >>>> >>>> and I got a segfault when running gcc on Alpine s390x chroot (built using a cross-compiler). >>> >>> Note that I know absolutely nothing about S/390 assembly, and this was just an outline of >>> how such a file would look like from my very quick skimming of the S/390 ABI and assembly >>> manuals. :P Someone with more knowledge of S/390 stuff should take a proper look at it. >>> >>> - Shiz >> >> Can you try the attached patch? > >> >From c61422be9eb3b5a4867feca5b0caf0da9c1f1a98 Mon Sep 17 00:00:00 2001 >> From: Bobby Bingham >> Date: Sun, 5 Feb 2017 21:29:52 -0600 >> Subject: [PATCH] s390x: implement dlsym >> >> This was missed when writing the port initially. >> --- >> src/ldso/s390x/dlsym.s | 6 ++++++ >> 1 file changed, 6 insertions(+) >> create mode 100644 src/ldso/s390x/dlsym.s >> >> diff --git a/src/ldso/s390x/dlsym.s b/src/ldso/s390x/dlsym.s >> new file mode 100644 >> index 00000000..2e9fa8fb >> --- /dev/null >> +++ b/src/ldso/s390x/dlsym.s >> @@ -0,0 +1,6 @@ >> + .global dlsym >> + .hidden __dlsym >> + .type dlsym,@function >> +dlsym: >> + lgr %r4, %r14 >> + jg __dlsym >> -- >> 2.11.0 >> > > Can anyone confirm whether this works? If so I'll commit it. > > Rich >