[musl] -frounding-math breaking src/math/acosf.c

[musl] -frounding-math breaking src/math/acosf.c

[joao]

Hi,

I just noticed that the upstream LLVM is no longer capable of compiling musl 1.2.0 (and possibly more recent versions too) when -frounding-math is in use. I bisected the LLVM commit to https://reviews.llvm.org/D87822, and pointed the problem there.

Just reporting in case someone else also has issues with this.

Best,
Joao.

Re: [musl] -frounding-math breaking src/math/acosf.c

[Rich Felker]

On Sat, Oct 10, 2020 at 12:16:13AM +0200, joao@overdrivepizza.com wrote:
> Hi,
> 
> I just noticed that the upstream LLVM is no longer capable of
> compiling musl 1.2.0 (and possibly more recent versions too) when
> -frounding-math is in use. I bisected the LLVM commit to
> https://reviews.llvm.org/D87822, and pointed the problem there.
> 
> Just reporting in case someone else also has issues with this.
> 
> Best,
> Joao.

Thanks. This probably needs to be reported as aa bug against LLVM (or
clang?) rather than just a comment on the review so that it's tracked
as such. It seems they've erroneously made it treat static
initializers as non-constant-expressions rather than evaluating them
statically in the default rounding mode per the spec.

Rich

Re: [musl] -frounding-math breaking src/math/acosf.c

[joao]

> Thanks. This probably needs to be reported as aa bug against LLVM (or
> clang?) rather than just a comment on the review so that it's tracked
> as such.

Makes sense, I'll submit/report it.

Re: [musl] -frounding-math breaking src/math/acosf.c

[Szabolcs Nagy]

* Rich Felker <dalias@libc.org> [2020-10-09 19:10:00 -0400]:

> On Sat, Oct 10, 2020 at 12:16:13AM +0200, joao@overdrivepizza.com wrote:
> > Hi,
> > 
> > I just noticed that the upstream LLVM is no longer capable of
> > compiling musl 1.2.0 (and possibly more recent versions too) when
> > -frounding-math is in use. I bisected the LLVM commit to
> > https://reviews.llvm.org/D87822, and pointed the problem there.
> > 
> > Just reporting in case someone else also has issues with this.
> > 
> > Best,
> > Joao.
> 
> Thanks. This probably needs to be reported as aa bug against LLVM (or
> clang?) rather than just a comment on the review so that it's tracked
> as such. It seems they've erroneously made it treat static
> initializers as non-constant-expressions rather than evaluating them
> statically in the default rounding mode per the spec.

const expressions should work as described in

http://port70.net/~nsz/c/c11/n1570.html#F.8.4

but it seems clang handles literals that don't
need conversion:

float x = 0.1f; // works
float y = 0.1; // fails

we may want to fix this anyway in musl to always
use the right type of literal (then it's clear
that there is no double rounding).

Re: [musl] -frounding-math breaking src/math/acosf.c

[Fangrui Song]

On Mon, Oct 12, 2020 at 2:40 AM Szabolcs Nagy <nsz@port70.net> wrote:
>
> * Rich Felker <dalias@libc.org> [2020-10-09 19:10:00 -0400]:
>
> > On Sat, Oct 10, 2020 at 12:16:13AM +0200, joao@overdrivepizza.com wrote:
> > > Hi,
> > >
> > > I just noticed that the upstream LLVM is no longer capable of
> > > compiling musl 1.2.0 (and possibly more recent versions too) when
> > > -frounding-math is in use. I bisected the LLVM commit to
> > > https://reviews.llvm.org/D87822, and pointed the problem there.
> > >
> > > Just reporting in case someone else also has issues with this.
> > >
> > > Best,
> > > Joao.
> >
> > Thanks. This probably needs to be reported as aa bug against LLVM (or
> > clang?) rather than just a comment on the review so that it's tracked
> > as such. It seems they've erroneously made it treat static
> > initializers as non-constant-expressions rather than evaluating them
> > statically in the default rounding mode per the spec.
>
> const expressions should work as described in
>
> http://port70.net/~nsz/c/c11/n1570.html#F.8.4

clang main has fixed (https://reviews.llvm.org/D89360) the regression
of https://reviews.llvm.org/D87822

> but it seems clang handles literals that don't
> need conversion:
>
> float x = 0.1f; // works
> float y = 0.1; // fails
>
> we may want to fix this anyway in musl to always
> use the right type of literal (then it's clear
> that there is no double rounding).