mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Dragan Mladjenovic <Dragan.Mladjenovic@syrmia.com>
To: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>,
	gcc-patches@gcc.gnu.org, Jeff Law <jeffreyalaw@gmail.com>,
	musl@lists.openwall.com
Subject: [musl] Re: [PATCH v2] configure: define TARGET_LIBC_GNUSTACK on musl
Date: Tue, 16 Nov 2021 15:40:00 +0100	[thread overview]
Message-ID: <7cfc5adb-64e8-7259-4c7e-26bb832cd00a@syrmia.com> (raw)
In-Reply-To: <20211116051323.4900-1-ilya.lipnitskiy@gmail.com>

Hi,

Looks fine to me. If possible, maybe it should even be back-ported to 
stable branches.

Not sure if MIPS assembly sources (if any) in musl would need explicit 
.note.GNU-stack

to complement this?

Best regards,

Dragan

On 16-Nov-21 06:13, Ilya Lipnitskiy wrote:
> musl only uses PT_GNU_STACK to set default thread stack size and has no
> executable stack support[0], so there is no reason not to emit the
> .note.GNU-stack section on musl builds.
>
> [0]: https://lore.kernel.org/all/20190423192534.GN23599@brightrain.aerifal.cx/T/#u
>
> gcc/ChangeLog:
>
> 	* configure: Regenerate.
> 	* configure.ac: define TARGET_LIBC_GNUSTACK on musl
>
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
> ---
>   gcc/configure    | 3 +++
>   gcc/configure.ac | 3 +++
>   2 files changed, 6 insertions(+)
>
> diff --git a/gcc/configure b/gcc/configure
> index 74b9d9be4c85..7091a838aefa 100755
> --- a/gcc/configure
> +++ b/gcc/configure
> @@ -31275,6 +31275,9 @@ fi
>   # Check if the target LIBC handles PT_GNU_STACK.
>   gcc_cv_libc_gnustack=unknown
>   case "$target" in
> +  mips*-*-linux-musl*)
> +    gcc_cv_libc_gnustack=yes
> +    ;;
>     mips*-*-linux*)
>   
>   if test $glibc_version_major -gt 2 \
> diff --git a/gcc/configure.ac b/gcc/configure.ac
> index c9ee1fb8919e..8a2d34179a75 100644
> --- a/gcc/configure.ac
> +++ b/gcc/configure.ac
> @@ -6961,6 +6961,9 @@ fi
>   # Check if the target LIBC handles PT_GNU_STACK.
>   gcc_cv_libc_gnustack=unknown
>   case "$target" in
> +  mips*-*-linux-musl*)
> +    gcc_cv_libc_gnustack=yes
> +    ;;
>     mips*-*-linux*)
>       GCC_GLIBC_VERSION_GTE_IFELSE([2], [31], [gcc_cv_libc_gnustack=yes], )
>       ;;

       reply	other threads:[~2021-11-16 14:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CALCv0x31=aZLuAE5e-_UR8pQZge9Tz5mwSxJJJ1JdQe6mxk5uA@mail.gmail.com>
     [not found] ` <20211116051323.4900-1-ilya.lipnitskiy@gmail.com>
2021-11-16 14:40   ` Dragan Mladjenovic [this message]
2021-11-16 16:25     ` Rich Felker
2021-11-16 17:49       ` Ilya Lipnitskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cfc5adb-64e8-7259-4c7e-26bb832cd00a@syrmia.com \
    --to=dragan.mladjenovic@syrmia.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ilya.lipnitskiy@gmail.com \
    --cc=jeffreyalaw@gmail.com \
    --cc=musl@lists.openwall.com \
    --subject='[musl] Re: [PATCH v2] configure: define TARGET_LIBC_GNUSTACK on musl' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).