From: Damian McGuckin <damianm@esi.com.au>
To: MUSL <musl@lists.openwall.com>
Subject: [musl] cacosh.c - Comment needs correction
Date: Fri, 8 Mar 2024 15:20:09 +1100 (AEDT) [thread overview]
Message-ID: <7e3d7940-60c8-2df9-2441-7acee57d7ba@esi.com.au> (raw)
The routine produces the correct answer.
However, currently, the comment at the top says
/* acosh(z) = i acos(z) */
I believe this is technically wrong;
To reflect the code, it should be changed to something like:
/* cacosh(z) = acosh(x +/- i y) = +/- i acos(x + i y) */
Somebody may want to rephrase that, i.e. if the sign of 'y' is positive
then the result is
i * cacos(z)
If the sign is negative, then the result is
-i * cacos(z)
I could always be wrong - Damian
next reply other threads:[~2024-03-08 4:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 4:20 Damian McGuckin [this message]
2024-03-08 4:44 ` [musl] " Damian McGuckin
2024-03-09 20:23 ` Szabolcs Nagy
2024-03-09 21:56 ` Damian McGuckin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e3d7940-60c8-2df9-2441-7acee57d7ba@esi.com.au \
--to=damianm@esi.com.au \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).