From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.2 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by inbox.vuxu.org (OpenSMTPD) with SMTP id a184cfe0 for ; Tue, 11 Feb 2020 14:20:09 +0000 (UTC) Received: (qmail 19636 invoked by uid 550); 11 Feb 2020 14:20:07 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 19618 invoked from network); 11 Feb 2020 14:20:06 -0000 X-ASG-Debug-ID: 1581430794-055413494605a30001-j9k7wl X-Barracuda-Envelope-From: mark@dibsco.co.uk X-Barracuda-Effective-Source-IP: cloud209.unlimitedwebhosting.co.uk[149.255.58.38] X-Barracuda-Apparent-Source-IP: 149.255.58.38 Authentication-Results: cloud209.unlimitedwebhosting.co.uk; spf=pass (sender IP is 212.139.44.2) smtp.mailfrom=mark@dibsco.co.uk smtp.helo=laptop.localnet Received-SPF: pass (cloud209.unlimitedwebhosting.co.uk: connection is authenticated) From: Mark Corbin To: musl@lists.openwall.com Cc: Rich Felker Date: Tue, 11 Feb 2020 14:19:53 +0000 X-ASG-Orig-Subj: Re: [musl] [PATCH] move riscv64 register index constants to signal.h Message-ID: <8177954.fbJeCJImAo@laptop> In-Reply-To: <20200204143136.GV1663@brightrain.aerifal.cx> References: <1815351.tyXQvQ9DpD@laptop> <20200204142631.GU1663@brightrain.aerifal.cx> <20200204143136.GV1663@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-PPP-Message-ID: <20200211141954.78052.86279@cloud209.unlimitedwebhosting.co.uk> X-PPP-Vhost: dibsco.co.uk X-Barracuda-Connect: cloud209.unlimitedwebhosting.co.uk[149.255.58.38] X-Barracuda-Start-Time: 1581430794 X-Barracuda-Encrypted: ECDHE-RSA-AES128-GCM-SHA256 X-Barracuda-URL: https://149.255.60.66:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at thundermail.uk X-Barracuda-Scan-Msg-Size: 1309 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=1.9 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.79931 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Subject: Re: [musl] [PATCH] move riscv64 register index constants to signal.h On Tuesday, 4 February 2020 14:31:36 GMT Rich Felker wrote: > On Tue, Feb 04, 2020 at 09:26:31AM -0500, Rich Felker wrote: > > > > > I guess that it would probably be best to change the libsigsegv code > > > > > to > > > > > use a value of '2' instead of the REG_SP definition. I'll look at > > > > > submitting a patch to the project. > > > > > > > > I think using a symbolic name is both more informative and more > > > > portable (since the layout of the saved registers is an OS choice, > > > > nothing universal to the architecture). The question is just where the > > > > macro should be obtained from. As long as glibc (and any other > > > > platforms that might be relevant?) has a sys/reg.h, it wouldn't hurt > > > > to just add the include and continue using the macro, regardless of > > > > whether musl moves it later. > > > > > > Glibc and uClibc don't have a sys/reg.h - is there a way that it could > > > be > > > included conditionally for musl only? > > > > If you want a configure test to detect it the yes; otherwise no. But > > this suggests the way we did it is wrong. We should not be making this > > kind of mess. I should probably just move the definitions... > > Patch attached. Any objections? > > Rich Thanks Rich, that solves the problem.