From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14207 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Leah Neukirchen Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 1/2] define daddr_t type Date: Fri, 07 Jun 2019 14:52:07 +0200 Message-ID: <874l518snc.fsf@vuxu.org> References: <20190607051444.20316-1-petr.vorel@gmail.com> <20190607052850.GO1506@brightrain.aerifal.cx> <20190607055329.GB7177@x230> <20190607055849.GR1506@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="86751"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: musl@lists.openwall.com To: Rich Felker Original-X-From: musl-return-14223-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 07 14:52:26 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hZEM5-000MRD-DY for gllmg-musl@m.gmane.org; Fri, 07 Jun 2019 14:52:25 +0200 Original-Received: (qmail 22221 invoked by uid 550); 7 Jun 2019 12:52:22 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 22203 invoked from network); 7 Jun 2019 12:52:22 -0000 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wlUHAPPTmGZUseQzV95SHDMHEAr/PEExNl7Up2cAxuc=; b=QJh8d1vfPZfWvRZ4Op+W1cMmhvf5IvNKNt47ve2XFVEJ+daC85m12KbdUE0Zw9uHVj fGKjkCcgBqB9lCY3Z6oRbI8QN9h7J16HdTR7U8sNu9JlIshBsgw0r6Gd9pbrj6VpjwZV 3o6e6/ApPV0YKf1fnrKIcCj6yoTdSHJGulvQYT0DCF30gQJyBxby/mNvzrXEtfGDvfTq fccnkV08xETKwD2PwkTE9RnIUt5apIdHCzuCgIoY4diEYXJt2RVDBpjeBX7bHk/QFX69 BOpooq9yUf63NVwttyUa3OXavSCsiJtHjXFDP3s8zCHmhcAkplv0VjE+Yi2Dvtlp+LB0 eYmA== X-Gm-Message-State: APjAAAV0lzD3Pip4bRr6K4TFxohzdQlGfCMPH82t3CAdmEZY9mE43O9w RI/VW1OQ3et2ekU+SREsADaYSj0FX5aIPg== X-Google-Smtp-Source: APXvYqy0t5Ws0eaGYmBPQis8R7iKaP30nDOvA9O0Iu/+UeZSeCwtH+Ejzqu87C5mhrCck6Anjvxrdg== X-Received: by 2002:a50:b566:: with SMTP id z35mr21430467edd.129.1559911930714; Fri, 07 Jun 2019 05:52:10 -0700 (PDT) In-Reply-To: <20190607055849.GR1506@brightrain.aerifal.cx> (Rich Felker's message of "Fri, 7 Jun 2019 01:58:49 -0400") Xref: news.gmane.org gmane.linux.lib.musl.general:14207 Archived-At: Rich Felker writes: > On Fri, Jun 07, 2019 at 07:53:29AM +0200, Petr Vorel wrote: >> Hi Rich, >> >> .... >> > > +++ b/include/sys/types.h >> > > @@ -29,6 +29,7 @@ extern "C" { >> > > #define __NEED_clock_t >> > > #define __NEED_suseconds_t >> > > #define __NEED_blksize_t >> > > +#define __NEED_daddr_t >> .... >> >> > daddr_t is not a standard type, so can't be exposed by default here >> > (aside from the dubious "*_t is always reserved" rule), and it's only >> So should it be wrapped by #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE) ? >> >> > proposed to be used in one header, so it doesn't belong in alltypes.h >> > either. >> Where should it be then? Shell I create bits/types.h for it? >> The goal is to be loadable from > > Why? It's not a reasonable type for any application to use -- we've > never gotten a report that something failed to build because of its > absence, and even if we did, it would almost surely be a case of "fix > the application". FWIW, Void patches four packages that use daddr_t: - gpart - kpartx - libtirpc - sleuthkit Additionally, five packages use caddr_t: - ifenslave - lwipv6 - macchanger - sbcl - virtuoso -- Leah Neukirchen http://leahneukirchen.org/