From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 26497 invoked from network); 19 Aug 2021 05:54:34 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 19 Aug 2021 05:54:34 -0000 Received: (qmail 27793 invoked by uid 550); 19 Aug 2021 05:54:32 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 27775 invoked from network); 19 Aug 2021 05:54:31 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629352460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=17cii1E6GLkimcC/GcO1HYOwoPpCP3ezI6xLA4CkNPc=; b=QHT1xPsPgTsWTdwP+CtoSMGMmxr0lBWdgRSrMF+TTgeXAmSfirdGF5sOW8LmvlKleXN7+v eQ+usREqzNoKJ0rn31g4eA14dKIU7jskCkPrW8NE3qq0oF3HFeMndJyEW743AyX8MUucB3 X7k3yF6DxE/B55aA7VphmGH6P7/qUg4= X-MC-Unique: K1b9PshEPq2N8FCKrzeSwg-1 From: Florian Weimer To: Rich Felker Cc: Olivier Galibert , musl@lists.openwall.com References: <20210818225222.81919-1-galibert@pobox.com> <20210819004903.GN13220@brightrain.aerifal.cx> Date: Thu, 19 Aug 2021 07:54:12 +0200 In-Reply-To: <20210819004903.GN13220@brightrain.aerifal.cx> (Rich Felker's message of "Wed, 18 Aug 2021 20:49:03 -0400") Message-ID: <878s0y2d4r.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=fweimer@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [musl] [PATCH] arm64/sigcontext: Synchronize the type of the __reserved field with the linux kernel. * Rich Felker: > On Thu, Aug 19, 2021 at 12:52:23AM +0200, Olivier Galibert wrote: >> clang's compiler-rt sanitizer_linux.cpp expects the __reserved field >> to be convertible to u8 *. So let's. >> --- >> arch/aarch64/bits/signal.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/aarch64/bits/signal.h b/arch/aarch64/bits/signal.h >> index 5098c734..a46997e3 100644 >> --- a/arch/aarch64/bits/signal.h >> +++ b/arch/aarch64/bits/signal.h >> @@ -19,7 +19,7 @@ typedef struct sigcontext { >> unsigned long fault_address; >> unsigned long regs[31]; >> unsigned long sp, pc, pstate; >> - long double __reserved[256]; >> + unsigned char __reserved[4096] __attribute__((__aligned__(16))); >> } mcontext_t; >> >> #define FPSIMD_MAGIC 0x46508001 > > The member name __reserved is not API, much less its particular type. The name is called __reserved, but it is actually part of the API. We learned this when we tried to rename it: The name and its __ prefix are rather unfortunate, but we are stuck with it. Thanks, Florian