From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14510 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Baruch Siach Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 2/2] fix risc64 user_regs_struct conflict with kernel header Date: Tue, 06 Aug 2019 15:15:47 +0300 Message-ID: <87imra7amk.fsf@tarshish> References: <63f4c551e85a848e336f41539b6dd283396eeda7.1565070674.git.baruch@tkos.co.il> <20190806121047.GT9017@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="37312"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.2.0; emacs 26.1 To: musl@lists.openwall.com Original-X-From: musl-return-14525-gllmg-musl=m.gmane.org@lists.openwall.com Tue Aug 06 14:16:03 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1huyNm-0009Xn-Bl for gllmg-musl@m.gmane.org; Tue, 06 Aug 2019 14:16:02 +0200 Original-Received: (qmail 32085 invoked by uid 550); 6 Aug 2019 12:16:00 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 32061 invoked from network); 6 Aug 2019 12:15:59 -0000 In-reply-to: <20190806121047.GT9017@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:14510 Archived-At: Hi Rick, On Tue, Aug 06 2019, Rich Felker wrote: > On Tue, Aug 06, 2019 at 08:51:14AM +0300, Baruch Siach wrote: >> Rename user_regs_struct following the example of s390 to avoid conflict >> with the kernel asm/ptrace.h header. >> --- >> arch/riscv64/bits/user.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/riscv64/bits/user.h b/arch/riscv64/bits/user.h >> index bd0f0fc7027f..097c7ad6ce18 100644 >> --- a/arch/riscv64/bits/user.h >> +++ b/arch/riscv64/bits/user.h >> @@ -1,4 +1,4 @@ >> -struct user_regs_struct { >> +struct _user_regs_struct { >> unsigned long pc; >> unsigned long ra; >> unsigned long sp; > > Does this agree with glibc naming? glibc riscv headers do not define user_regs_struct. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -