From: Florian Weimer <fweimer@redhat.com>
To: "Zack Weinberg" <zack@owlfolio.org>
Cc: "Gabriel Ravier" <gabravier@gmail.com>,
"Rich Felker" <dalias@libc.org>,
"Skyler Ferrante (RIT Student)" <sjf5462@rit.edu>,
musl@lists.openwall.com, "Andreas Schwab" <schwab@suse.de>,
"Alejandro Colomar" <alx@kernel.org>,
"Thorsten Glaser" <tg@mirbsd.de>, NRK <nrk@disroot.org>,
"Guillem Jover" <guillem@hadrons.org>,
"GNU libc development" <libc-alpha@sourceware.org>,
libbsd@lists.freedesktop.org,
"Serge E. Hallyn" <serge@hallyn.com>,
"Iker Pedrosa" <ipedrosa@redhat.com>,
"Christian Brauner" <christian@brauner.io>
Subject: Re: [musl] Re: Tweaking the program name for <err.h> functions
Date: Tue, 12 Mar 2024 15:31:04 +0100 [thread overview]
Message-ID: <87o7bjttcn.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <84bf19d7-c2ba-46e7-a77d-ecc6497f08a1@app.fastmail.com> (Zack Weinberg's message of "Tue, 12 Mar 2024 10:21:19 -0400")
* Zack Weinberg:
> On Tue, Mar 12, 2024, at 9:54 AM, Florian Weimer wrote:
>>> Doing this would break many programs, such as:
>>> - most of coreutils, e.g. programs like ls, cat or head, since they
>>> always `close` their input and output descriptors (when they've
>>> written or read something) to make sure to diagnose all errors
>>
>> A slightly better way to do this is to do fflush (stdout) followed by
>> error checking on close (dup (fileno (stdout))).
>
> Does that actually report delayed write errors? As you have it,
> the close() just drops the fd created by the dup(), the OFD is
> still referenced by fd 1 and therefore remains open.
I don't think the VFS close action is subject to reference counting.
Otherwise the current coreutils error checking wouldn't work because in
many cases, another process retains a reference to the OFD.
Thanks,
Florian
next prev parent reply other threads:[~2024-03-12 14:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Zeo-oJOyN9YQXVb1@debian>
[not found] ` <ZepcO2pa0cwsqr3u@thunder.hadrons.org>
2024-03-08 0:52 ` Alejandro Colomar
2024-03-09 15:02 ` Rich Felker
2024-03-09 15:49 ` Alejandro Colomar
2024-03-09 18:35 ` Andreas Schwab
2024-03-09 18:46 ` Alejandro Colomar
2024-03-09 19:18 ` Markus Wichmann
2024-03-09 19:25 ` Rich Felker
2024-03-09 21:44 ` Thorsten Glaser
2024-03-10 6:01 ` NRK
2024-03-10 13:17 ` Alejandro Colomar
2024-03-10 14:01 ` NRK
2024-03-10 19:39 ` Rich Felker
2024-03-10 22:25 ` Alejandro Colomar
2024-03-10 23:22 ` Thorsten Glaser
2024-03-10 23:44 ` Rich Felker
2024-03-11 0:19 ` Thorsten Glaser
2024-03-11 0:46 ` Alejandro Colomar
2024-03-11 14:46 ` Skyler Ferrante (RIT Student)
2024-03-11 15:09 ` Andreas Schwab
2024-03-11 15:30 ` Skyler Ferrante (RIT Student)
2024-03-11 18:23 ` Florian Weimer
2024-03-11 18:48 ` Skyler Ferrante (RIT Student)
2024-03-11 19:05 ` enh
2024-03-11 19:44 ` Rich Felker
2024-03-11 20:35 ` enh
2024-03-11 19:47 ` Rich Felker
2024-03-11 20:08 ` Skyler Ferrante (RIT Student)
2024-03-11 20:39 ` enh
2024-03-11 21:21 ` Laurent Bercot
2024-03-11 22:05 ` Thorsten Glaser
2024-03-12 0:18 ` Gabriel Ravier
2024-03-12 0:43 ` Rich Felker
2024-03-12 3:23 ` Gabriel Ravier
2024-03-12 14:44 ` Rich Felker
2024-03-12 13:54 ` Florian Weimer
2024-03-12 14:21 ` Zack Weinberg
2024-03-12 14:31 ` Florian Weimer [this message]
2024-03-12 14:42 ` Rich Felker
2024-03-12 19:25 ` Zack Weinberg
2024-03-12 21:19 ` Rich Felker
2024-03-13 8:28 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7bjttcn.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=alx@kernel.org \
--cc=christian@brauner.io \
--cc=dalias@libc.org \
--cc=gabravier@gmail.com \
--cc=guillem@hadrons.org \
--cc=ipedrosa@redhat.com \
--cc=libbsd@lists.freedesktop.org \
--cc=libc-alpha@sourceware.org \
--cc=musl@lists.openwall.com \
--cc=nrk@disroot.org \
--cc=schwab@suse.de \
--cc=serge@hallyn.com \
--cc=sjf5462@rit.edu \
--cc=tg@mirbsd.de \
--cc=zack@owlfolio.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).