From: Leah Neukirchen <leah@vuxu.org>
To: musl@lists.openwall.com
Subject: Out-of-bounds read in twobyte_memmem
Date: Thu, 29 Jun 2017 15:37:19 +0200 [thread overview]
Message-ID: <87r2y2vrsg.fsf@gmail.com> (raw)
Hello,
As mentioned in #musl, twobyte_memmem in memmem.c does an out of
bounds read to the byte after the final byte of the buffer, when it
updates hw using *++h before checking k. Similar code in strstr is
unproblematic since there it will only read the NUL terminator.
Proposed solution is to rewrite the for-loop to make control flow
order explicit, but there may be a more idiomatic solution than this:
static char *twobyte_memmem(const unsigned char *h, size_t k, const unsigned char *n)
{
uint16_t nw = n[0]<<8 | n[1], hw = h[0]<<8 | h[1];
h++;
k--;
for (;;) {
if (hw == nw) return (char *)h-1;
if (!--k) return 0;
hw = hw<<8 | *++h;
}
return 0;
}
This bug was detected by @mourais during development of mblaze on
OpenBSD, using MALLOC_OPTIONS=G.
Thanks,
--
Leah Neukirchen <leah@vuxu.org> http://leah.zone
next reply other threads:[~2017-06-29 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 13:37 Leah Neukirchen [this message]
2017-06-29 21:35 ` [RFC PATCH] fix OOB reads in Xbyte_memmem Alexander Monakov
2017-06-29 21:48 ` Rich Felker
2017-07-10 18:11 ` Alexander Monakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2y2vrsg.fsf@gmail.com \
--to=leah@vuxu.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).