From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 10086 invoked from network); 27 Oct 2021 14:35:14 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 27 Oct 2021 14:35:14 -0000 Received: (qmail 7230 invoked by uid 550); 27 Oct 2021 14:35:10 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 7198 invoked from network); 27 Oct 2021 14:35:09 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=eeJAWhjtunHSELV7t/32IBauUI W4L3uf9fiGP1WFM98=; b=P7RDi0VWO1XW/NxkOz859/HIcMiLDxhY3/lrFrCh9G 8zBFs8RTMfIo3dIBzc2CntS1RcEz1F20WhGzhE7w6GXWyDDGpWmW7A2khjBUuWeB uaD+KyWdBIH/gFfY1mJZruk7q5OtGTK4g8blvFBKaPA4fGh5JiyiojL+y6Pa5XaN e4R6w1Rd2WkVwZZTprwsi04D176j0qO1p/g0LblnLOanLEQsMc7JnVoG6OhhJ6gd o6trYj3LYMwoAIBV/yKf+J+fXHwQ/Eyb72q0pIcgYkZNvU8P2PyPiCZjdXKsz34c pASVWEixPCNCxnudvEQQhw5MGPZ1Ym6fgo8ERHxgXUmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=eeJAWh jtunHSELV7t/32IBauUIW4L3uf9fiGP1WFM98=; b=c1u8pTlcvB3alHGSNhd1uf pxzKJ4LbL5OEQPJ9cj1fysqFcain+/Q3RELXhplxOit69owNCZMILzbPQPdWzRmR bCNrEYi0GbxfHo7TmN9iHvI91mYy+oYU4GmczPoLted+hfrsglu+ZM01P/5/2qBr UmM4hxbEjbROemWSVoWY539RwaeFuZdzABosx1KiFYxT6HLtW/kD+wDCwrQLGL5o VLWJU3lL9EZvnbBWajUMwGH8GOOfeZqtCXUGKhp7CncUsCELek1k+nqNJjFibFz4 8xY82SGd3zM1+e/+aNr8t/YazFRODw5OKxmxMWX7G40qvqahn9OabPeEQBY2DYmA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdegtddgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesghdtreertddtjeenucfhrhhomheptehlhihsshgr ucftohhsshcuoehhihesrghlhihsshgrrdhisheqnecuggftrfgrthhtvghrnhepffduud ffueffgeehieegjedtkefhudehheefudehlefftedtkeeitdegfefgleehnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephhhisegrlhihshhsrg drihhs X-ME-Proxy: From: Alyssa Ross To: Rich Felker , "(GalaxyMaster)" Cc: musl@lists.openwall.com, 2010267516@qq.com, Kaihang Zhang In-Reply-To: <20211012125942.GH7074@brightrain.aerifal.cx> References: <20211012023643.44509-1-kaihang.zhang@smartx.com> <0100017c7287622f-cceed952-52dc-4c02-b1af-b3943a41203c-000000@email.amazonses.com> <20211012125942.GH7074@brightrain.aerifal.cx> Date: Wed, 27 Oct 2021 14:34:49 +0000 Message-ID: <87sfwmtu2e.fsf@alyssa.is> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Subject: [musl] Changes to getmntent --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Rich Felker writes: > Yes. There are actually several conflicting proposed changes to this > (frustratingly underspecified, and with bad behavior by glibc) > function, and so far there's been little engagement between different > people who want it changed/fixed to resolve the differences. I would > really like to see from at least one party who wants it changed a > summary of what the differences are between the different proposals, > what musl is doing now, and what glibc is doing now, and > justifications for why their preferred one is okay (including > capability for applications to recover and not silently use wrong data > -- "glibc lets them silently use wrong data" isn't a justification). > > Rich Hi, I'm somebody who has proposed changes to getmntent recently, so here I am specifying what I'd like it to do: =E2=80=A2 Lines starting with "#" should be skipped. =E2=80=A2 Empty lines should be skipped. =E2=80=A2 The fifth and sixth fields should be optional. All of these changes are things that glibc does today, and musl does not. Hopefully it's pretty obvious why the first two are good ideas. As for the third, I think it's a change to be made because the last two fields (dump frequency, and pass number on parallel fsck) are obscure and not required to mount the filesystem, and because fstab(5) says they're optional. The approach I've been taking so far is to send a series containing interspersed patches to libc-test and musl, with the idea that libc-test could be the place where we specify how genmntent should work. Perhaps, to accelerate the process of getting everybody on the same page, it would be better to concentrate on getting tests into libc-test that describe the behaviour we think musl should have, and once that's done begin to look at changing musl's implementation to pass the test. Would that be a good way forward? I'd be happy to kick things off with a patch to libc-test that tests basic functionality and all the behaviour changes I'd like to have made, if Rich is happy to go that way. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmF5Y4oACgkQ+dvtSFmy ccD0Gw//QGwppBybECUvYTWfCkiWc2lv+upymSvpUPoUSkDT35VYtAN86skmLONc TBfp1kbRBS2UdSDS56UqQnAZbaRZqOPlGnLrSiqOG6evUi2XELXAKUoB1ZKyh4za 4D3J5e/q5Bla8W5DOeZWr5L3Ea4esAh8u2S6qjGgEMVjQu46VnNa5f2ntKMCMFtx kLBbey5arSr70rhiqrUwNAeOQPdmPFD/PX53SxL5S/AwFYRvwKiNh3aQroYtIDnk Pk8Moymh37OVEOIWQwMnZgBhGBNdRLGLvOJdrbHJB4jxXsX1vW2xxMG0z4f10ksu rDZjTI39884dwjqNkO/d+s45ptKX6yKZN0+S+bxx5SY60jwqQznOyyNP0wOxYdVg rG2MkayXrp5D4kgfl8mw08JNTMya8XbxY/OmjoNHZFcO1QbDqY9VcTtO8ewPhV2Z t6OfG5i49Q9Ti8LfeQ1lzCmB3DgFPMCKomwnDnPzVzIBdpX+jWSoVUJ6v/6bQ9o7 kWPvlmlZUaabH8azIrJJcERKGUpF4v30AQPMEmRr+ATx4rDeOoydf6xHzOQ3xMsO 1vuuo/w3MbSysh3MEcqx01DHTsCaTVcNDcegSEZw02fHNYNrrHr1U39KuPh/mCxR pb9eM1ezzbfye7Sdw66H4Z6W1uTbGdcAyh0XBd4ext3R5rQPYwQ= =N17t -----END PGP SIGNATURE----- --=-=-=--