From: Julian Squires <julian@cipht.net>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] getaddrinfo/AI_ADDRCONFIG with ipv6 disabled
Date: Fri, 30 Apr 2021 15:29:17 -0230 [thread overview]
Message-ID: <87v983fybu.fsf@quelaan> (raw)
In-Reply-To: <20210430165238.GY2546@brightrain.aerifal.cx> (Rich Felker's message of "Fri, 30 Apr 2021 12:52:38 -0400")
Rich Felker <dalias@libc.org> writes:
> So in light of this mess, the patch may be correct, despite the
> problem being misattributed, but it should probably also handle the
> EINVAL case. Also it's not 100% clear whether we should interpret this
> as "no IPv6" or ignore it as an access control policy rather than
> reflection of IPv6 existing. If there are any other ways the kernel
> can return EACCES or EINVAL here, we would not want to misinterpret
> that in a way that breaks IPv6.
I've sent an updated patch to the list. I did submit a change to
OpenWrt to not create these rules on devices where IPv6 is disabled:
https://patchwork.ozlabs.org/project/openwrt/patch/20210430143037.6763-1-julian@cipht.net/
but it seems to me that the patch to musl still makes sense, in as much
as these return codes from Linux make any sense at all.
<#secure method=pgpmime mode=sign>
--
Julian Squires
next prev parent reply other threads:[~2021-04-30 18:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 2:44 Bob Richmond
2021-04-30 0:13 ` [musl] " Rich Felker
2021-04-30 12:38 ` Rich Felker
2021-04-30 16:40 ` Bastian Bittorf
2021-04-30 16:52 ` Rich Felker
2021-04-30 17:59 ` Julian Squires [this message]
2021-04-30 16:59 ` Jeffrey Walton
2021-04-30 18:49 ` Markus Wichmann
2021-04-30 19:50 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v983fybu.fsf@quelaan \
--to=julian@cipht.net \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).