From: Florian Weimer <fweimer@redhat.com>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] __WORDSIZE on x32
Date: Tue, 23 Nov 2021 21:22:24 +0100 [thread overview]
Message-ID: <87y25eoc5b.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20211123201438.GA7074@brightrain.aerifal.cx> (Rich Felker's message of "Tue, 23 Nov 2021 15:14:38 -0500")
* Rich Felker:
> On Tue, Nov 23, 2021 at 08:51:36PM +0100, Florian Weimer wrote:
>> This looks a bid suspicious:
>
> Come on, you missed a chance to say "sus". :-)
Sorry? I typo'ed “bit”, but that's not it?
>> arch/x32/bits/reg.h:#undef __WORDSIZE
>> arch/x32/bits/reg.h:#define __WORDSIZE 32
>> arch/x32/bits/user.h:#undef __WORDSIZE
>> arch/x32/bits/user.h:#define __WORDSIZE 64
>>
>> I don't know if it causes any actual problems. I discovered it while
>> checking whether musl defines/uses __WORDSIZE.
>
> Thanks for the find. Now... which is it supposed to be?
>
> commit 664cd341921007cea52c8891f27ce35927dca378 introduced x32 as a
> patch against a copy of x86_64 and changed one instance from 64 to 32,
> so presumably the intent was to change both. Is this in agreement with
> what it means on glibc or elsewhere?
glibc uses __WORDSIZE == 64 to differentiate x86-64 from x86-64-32, so
it should be 32 for x32.
However, arch/x32/bits/user.h looks written as if define __WORDSIZE to
64 changes the width of long to 64. I think struct user_regs_struct
needs to have unsigned long long members on x32. (It's what glibc uses
for both x86-64 and x86-64-32.) Likewise a most of the members of
struct user.
Thanks,
Florian
next prev parent reply other threads:[~2021-11-23 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 19:51 Florian Weimer
2021-11-23 20:14 ` Rich Felker
2021-11-23 20:22 ` Florian Weimer [this message]
2022-03-08 21:59 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y25eoc5b.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).