mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Richard Gorton <rcgorton@cognitive-electronics.com>
To: musl@lists.openwall.com
Subject: Re: magic constants in some startup code
Date: Fri, 31 Oct 2014 10:31:45 -0400	[thread overview]
Message-ID: <8B3E5DDE-2691-4377-8934-362ACC7BEA69@cognitive-electronics.com> (raw)
In-Reply-To: <20141031141844.GA22465@brightrain.aerifal.cx>

Thank you (and a follow up question) - what code looks at this canary?  It is assigned to pthread_self()->canary, but I do not see any code inside musl itself that checks that value?  A work in progress?  Or does other code check this value?

Regards,
	Richard

On Oct 31, 2014, at 10:18 AM, Rich Felker <dalias@libc.org> wrote:
> 
>> ----
>> 
>> src/env/__stack_chk_fail.c
>> 	else __stack_chk_guard = (uintptr_t)&__stack_chk_guard * 1103515245;
>> 
>> the number equates to 0x41c64e6d.
>> Called from __init_libc as:
>> 	 __init_ssp((void *)aux[AT_RANDOM]); 
>> The kernel is putting a random number into aux[AT_RANDOM] at process initialization.
>> Why not just put a predictable arbitrary number into __stack_chk_guard?
> 
> The reason you don't want a predictable arbitrary number for the stack
> guard canary is that it makes it easy to bypass stack-protector by
> including the known number in your overflow payload.
> 
> The idea in the above code, which really deserves a comment, is to
> attempt to recover _some_ entropy from the address at which libc is
> mapped (which hopefully was affected by ASLR) when AT_RANDOM is not
> available. Modern Linux kernels always give you AT_RANDOM, so this
> code path would only be taken on an ancient Linux version or a
> non-Linux host.
> 
> The magic number 1103515245 is just a LCG, the same as what's used in
> musl's rand_r() and in the C standard's sample rand(). It serves to
> mix the bits somewhat, accounting for the likelihood that the mapping
> address is not very random in some of its bits.
> 
> None of this is really very effective, but I've left it there because
> it seems "better than nothing".
> 
> Rich



  reply	other threads:[~2014-10-31 14:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31 13:31 Richard Gorton
2014-10-31 14:18 ` Rich Felker
2014-10-31 14:31   ` Richard Gorton [this message]
2014-10-31 16:09     ` Rich Felker
2014-10-31 20:19       ` Andy Lutomirski
2014-10-31 21:05         ` Rich Felker
2014-10-31 21:29           ` Andy Lutomirski
2014-10-31 21:39             ` Rich Felker
2014-10-31 22:27               ` Andy Lutomirski
2014-10-31 23:14                 ` Rich Felker
2014-11-02 17:17                   ` Szabolcs Nagy
2014-11-02 19:10                     ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8B3E5DDE-2691-4377-8934-362ACC7BEA69@cognitive-electronics.com \
    --to=rcgorton@cognitive-electronics.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).