From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8540 Path: news.gmane.org!not-for-mail From: Vasileios Kalintiris Newsgroups: gmane.linux.lib.musl.general Subject: RE: [PATCH] Define and use the __ptrace_request enumeration type in ptrace. Date: Mon, 21 Sep 2015 21:39:50 +0000 Message-ID: <8B7D5EC97CB15C4DBFDCE766959C1607C6C43E@hhmail02.hh.imgtec.org> References: <8B7D5EC97CB15C4DBFDCE766959C1607C6ABD1@hhmail02.hh.imgtec.org>,<20150921203126.GU17773@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1442871614 2148 80.91.229.3 (21 Sep 2015 21:40:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Sep 2015 21:40:14 +0000 (UTC) To: "musl@lists.openwall.com" Original-X-From: musl-return-8552-gllmg-musl=m.gmane.org@lists.openwall.com Mon Sep 21 23:40:08 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Ze8og-0002q3-Bu for gllmg-musl@m.gmane.org; Mon, 21 Sep 2015 23:40:06 +0200 Original-Received: (qmail 21611 invoked by uid 550); 21 Sep 2015 21:40:04 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 21592 invoked from network); 21 Sep 2015 21:40:03 -0000 Thread-Topic: [musl] [PATCH] Define and use the __ptrace_request enumeration type in ptrace. Thread-Index: AdDxUP0t/GsheGLGS7CtBdVOt5GpuQDUx3oAAAR2v1E= In-Reply-To: <20150921203126.GU17773@brightrain.aerifal.cx> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [151.224.28.152] Xref: news.gmane.org gmane.linux.lib.musl.general:8540 Archived-At: Hi Rich,=0A= =0A= Thank you for taking the time to look into this.=0A= =0A= > Is there a particular problem you're trying to solve here?=0A= =0A= I tried to compile LLDB with musl and I found two places where=0A= the __ptrace_request type is being used:=0A= =0A= http://reviews.llvm.org/diffusion/L/browse/lldb/trunk/source/Plugins/Proces= s/Linux/NativeProcessLinux.cpp;248212$3161=0A= =0A= > Generally enum is avoided in musl unless it's mandated as part of an=0A= > interface definition.=0A= =0A= I based my patch on the definition provided by ptrace(2) on my Linux distro= ,=0A= thinking that this is the "correct" function prototype that we should provi= de.=0A= =0A= > As written, I think the patch would also be a regression that would break= =0A= > apps which test for header/library support of a particular PTRACE_* comma= nd=0A= > using #ifdef.=0A= =0A= I do understand your concerns, I suppose that fixing this from the LLDB sid= e=0A= will solve the mis-compilation problem and will keep us from introducing a= =0A= regression to other apps from musl.=0A= =0A= Out of curiosity, what is the general implementation choice in this case in= =0A= other C libraries? I'm asking because discovering GLIBC and handing it as a= =0A= special case would be easy through the __GLIBC__ macro. However, musl doesn= 't=0A= provide any such macro (and other C libraries probably).=0A= =0A= Thanks,=0A= Vasileios=