From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14834 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Hauke Mehrtens Newsgroups: gmane.linux.kernel.stable,gmane.linux.lib.musl.general,gmane.linux.ports.arm.kernel,gmane.linux.kernel,gmane.linux.kernel.api Subject: Re: [musl] [PATCH] arm64: uapi: Fix user space compile with musl libc Date: Sat, 19 Oct 2019 23:51:51 +0200 Message-ID: <8fcff553-3309-7153-b245-6593d2728678@hauke-m.de> References: <20191019201717.15358-1-hauke@hauke-m.de> <20191019202950.GC16318@brightrain.aerifal.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="204169"; mail-complaints-to="usenet@blaine.gmane.org" Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, stable@vger.kernel.org To: musl@lists.openwall.com, Rich Felker Original-X-From: stable-owner@vger.kernel.org Sat Oct 19 23:52:06 2019 Return-path: Envelope-to: glks-stable4@m.gmane.org Original-Received: from vger.kernel.org ([209.132.180.67]) by blaine.gmane.org with esmtp (Exim 4.89) (envelope-from ) id 1iLwdp-000qwJ-DB for glks-stable4@m.gmane.org; Sat, 19 Oct 2019 23:52:05 +0200 Original-Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726145AbfJSVwB (ORCPT ); Sat, 19 Oct 2019 17:52:01 -0400 Original-Received: from mx2a.mailbox.org ([80.241.60.219]:47915 "EHLO mx2a.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726143AbfJSVwB (ORCPT ); Sat, 19 Oct 2019 17:52:01 -0400 Original-Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2a.mailbox.org (Postfix) with ESMTPS id 4239FA3391; Sat, 19 Oct 2019 23:51:57 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Original-Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id SVBYNqVDiOMf; Sat, 19 Oct 2019 23:51:53 +0200 (CEST) Openpgp: preference=signencrypt Autocrypt: addr=hauke@hauke-m.de; keydata= mQINBFtLdKcBEADFOTNUys8TnhpEdE5e1wO1vC+a62dPtuZgxYG83+9iVpsAyaSrCGGz5tmu BgkEMZVK9YogfMyVHFEcy0RqfO7gIYBYvFp0z32btJhjkjBm9hZ6eonjFnG9XmqDKg/aZI+u d9KGUh0DeaHT9FY96qdUsxIsdCodowf1eTNTJn+hdCudjLWjDf9FlBV0XKTN+ETY3pbPL2yi h8Uem7tC3pmU7oN7Z0OpKev5E2hLhhx+Lpcro4ikeclxdAg7g3XZWQLqfvKsjiOJsCWNXpy7 hhru9PQE8oNFgSNzzx2tMouhmXIlzEX4xFnJghprn+8EA/sCaczhdna+LVjICHxTO36ytOv7 L3q6xDxIkdF6vyeEtVm1OfRzfGSgKdrvxc+FRJjp3TIRPFqvYUADDPh5Az7xa1LRy3YcvKYx psDDKpJ8nCxNaYs6hqTbz4loHpv1hQLrPXFVpoFUApfvH/q7bb+eXVjRW1m2Ahvp7QipLEAK GbiV7uvALuIjnlVtfBZSxI+Xg7SBETxgK1YHxV7PhlzMdTIKY9GL0Rtl6CMir/zMFJkxTMeO 1P8wzt+WOvpxF9TixOhUtmfv0X7ay93HWOdddAzov7eCKp4Ju1ZQj8QqROqsc/Ba87OH8cnG /QX9pHXpO9efHcZYIIwx1nquXnXyjJ/sMdS7jGiEOfGlp6N9IwARAQABtCFIYXVrZSBNZWhy dGVucyA8aGF1a2VAaGF1a2UtbS5kZT6JAlQEEwEIAD4CGwEFCwkIBwIGFQgJCgsCBBYCAwEC HgECF4AWIQS4+/Pwq1ZO6E9/sdOT3SBjCRC1FQUCXQ In-Reply-To: <20191019202950.GC16318@brightrain.aerifal.cx> Content-Language: en-US Original-Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Xref: news.gmane.org gmane.linux.kernel.stable:381714 gmane.linux.lib.musl.general:14834 gmane.linux.ports.arm.kernel:761917 gmane.linux.kernel:3258374 gmane.linux.kernel.api:38077 Archived-At: On 10/19/19 10:29 PM, Rich Felker wrote: > On Sat, Oct 19, 2019 at 10:17:17PM +0200, Hauke Mehrtens wrote: >> musl libc also defines the structures in their arch/aarch64/bits/signal.h >> header file. Some applications like strace and gdb include both of them >> and then the structure definitions are clashing and the build of these >> user space applications fails. >> >> This patch allows a libc to define a constant which tells the kernel >> header file that the libc already defined these structures and that they >> should not be defined by the kernel uapi header files any more to >> prevent clashes. This is done in a similar way as it is already done for >> other header files. >> >> When this patch was accepted into the kernel I will also update musl >> libc to define these constants. > > I don't entirely object to this outright, but I'd really like to avoid > adding further __UAPI_DEF_* suppressions. AIUI asm/sigcontext.h is not > intended to be used with userspace headers. Is it still being > indirectly included via some other uapi headers? (I thought that was > fixed..) If so, that should really be fixed first, and then we can see > if there's still motivation for the patch here. > > Rich > Hi Rich, I did some more research and it looks like this patch also fixes my problem with strace and gdb compile: https://git.kernel.org/linus/9966a05c7b80f075f2bc7e48dbb108d3f2927234 I will backport it in OpenWrt to kernel 4.19. Please drop my patch. It would be nice if it could go into the stable 4.19 kernel. Hauke